setup_storage aborts on UnboundLocalError: local variable 'ceph_new_version' referenced before assignment

[wenqing liang]

setup_storage of mainline 2740 liberty aborts:

2016-07-12 11:09:12:990250: [root@10.87.140.197] out: [5.0.0.1] out: Traceback (most recent call last):
2016-07-12 11:09:13:054102: [root@10.87.140.197] out: [5.0.0.1] out: File "/usr/bin/storage-fs-setup", line 9, in <module>
2016-07-12 11:09:13:054315: [root@10.87.140.197] out: [5.0.0.1] out: load_entry_point('ContrailProvisioning==0.1dev', 'console_scripts', 'storage-fs-setup')()
2016-07-12 11:09:13:054363: [root@10.87.140.197] out: [5.0.0.1] out: File "/usr/local/lib/python2.7/dist-packages/contrail_provisioning/storage/storagefs/setup.py", line 3960, in main
2016-07-12 11:09:13:054412: [root@10.87.140.197] out: [5.0.0.1] out: SetupCeph(args_str)
2016-07-12 11:09:13:054450: [root@10.87.140.197] out: [5.0.0.1] out: File "/usr/local/lib/python2.7/dist-packages/contrail_provisioning/storage/storagefs/setup.py", line 3820, in __init__
2016-07-12 11:09:13:054486: [root@10.87.140.197] out: [5.0.0.1] out: self.do_patch_ceph_deploy()
2016-07-12 11:09:13:054533: [root@10.87.140.197] out: [5.0.0.1] out: File "/usr/local/lib/python2.7/dist-packages/contrail_provisioning/storage/storagefs/setup.py", line 550, in do_patch_ceph_deploy
2016-07-12 11:09:13:054569: [root@10.87.140.197] out: [5.0.0.1] out: ceph_deploy_patch_utils.create_and_apply_ceph_deploy_patch()
2016-07-12 11:09:13:054605: [root@10.87.140.197] out: [5.0.0.1] out: File "/usr/local/lib/python2.7/dist-packages/contrail_provisioning/storage/storagefs/ceph_utils.py", line 1860, in create_and_apply_ceph_deploy_patch
2016-07-12 11:09:13:054641: [root@10.87.140.197] out: [5.0.0.1] out: if ceph_new_version == True:
2016-07-12 11:09:13:054686: [root@10.87.140.197] out: [5.0.0.1] out: UnboundLocalError: local variable 'ceph_new_version' referenced before assignment
2016-07-12 11:09:13:054722: [root@10.87.140.197] out: [5.0.0.1] out:
2016-07-12 11:09:13:255565: [root@10.87.140.197] out:
2016-07-12 11:09:13:255725: [root@10.87.140.197] out:
2016-07-12 11:09:13:255807: [root@10.87.140.197] out: Fatal error: run() received nonzero return code 1 while executing!
2016-07-12 11:09:13:255887: [root@10.87.140.197] out:

Jul 12 11:07:17 cmbu-ceph-perf1 puppet-agent[29918]: Unable to fetch my node definition, but the agent run will continue:
Jul 12 11:07:17 cmbu-ceph-perf1 puppet-agent[29918]: Find /production/node/cmbu-ceph-perf1.englab.juniper.net?transaction_uuid=c98a47ad-ac10-4518-b6f5-5a41... resulted in 404 with the message: Not Found: Could not find node cmbu-ceph-perf1.englab.juniper.net
Jul 12 11:07:17 cmbu-ceph-perf1 puppet-agent[29918]: Could not retrieve catalog from remote server: Error 400 on SERVER: Could not find node 'cmbu-ceph-perf1.englab.juniper.net'; cannot compile
Jul 12 11:07:17 cmbu-ceph-perf1 puppet-agent[29918]: Not using cache on failed catalog
Jul 12 11:07:17 cmbu-ceph-perf1 puppet-agent[29918]: Could not retrieve catalog; skipping run
Jul 12 11:07:20 cmbu-ceph-perf1 Keepalived_healthcheckers[1330]: Timeout connect, timeout server [192.168.200.2]:1358.
Jul 12 11:07:20 cmbu-ceph-perf1 Keepalived_healthcheckers[1330]: Timeout connect, timeout server [192.168.200.4]:1358.
Jul 12 11:07:20 cmbu-ceph-perf1 Keepalived_healthcheckers[1330]: Timeout connect, timeout server [192.168.200.5]:1358.
Jul 12 11:07:22 cmbu-ceph-perf1 Keepalived_healthcheckers[1330]: Timeout connect, timeout server [192.168.200.3]:1358.
Jul 12 11:07:22 cmbu-ceph-perf1 Keepalived_healthcheckers[1330]: Timeout connect, timeout server [192.168.201.100]:443.
Jul 12 11:07:26 cmbu-ceph-perf1 Keepalived_healthcheckers[1330]: Timeout connect, timeout server [192.168.200.2]:1358.
Jul 12 11:07:26 cmbu-ceph-perf1 Keepalived_healthcheckers[1330]: Timeout connect, timeout server [192.168.200.4]:1358.
Jul 12 11:07:26 cmbu-ceph-perf1 Keepalived_healthcheckers[1330]: Timeout connect, timeout server [192.168.200.5]:1358.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/21892
Submitter: Jeya ganesh babu (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/21893
Submitter: Jeya ganesh babu (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/21892
Submitter: Jeya ganesh babu (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/21893
Committed: http://github.org/Juniper/contrail-provisioning/commit/9330dcaa6c6068127c48aaf8bc166736f7f764d9
Submitter: Zuul
Branch: R3.1

commit 9330dcaa6c6068127c48aaf8bc166736f7f764d9
Author: Jeya ganesh babu J <email address hidden>
Date: Tue Jul 12 12:29:26 2016 -0700

Storage provision fix

Closes-Bug: #1602390
Closes-Bug: #1602384
Fixed issue in initializing version variable and openstack node
variable, causing storage setup to abort.

Change-Id: I36f94038bda8a9549ea78f6438337dc4b4ace6fd

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/21892
Committed: http://github.org/Juniper/contrail-provisioning/commit/23187e3c8d919f1efdb42317fe5b4679be5cad00
Submitter: Zuul
Branch: master

commit 23187e3c8d919f1efdb42317fe5b4679be5cad00
Author: Jeya ganesh babu J <email address hidden>
Date: Tue Jul 12 12:17:27 2016 -0700

Storage provision fix

Closes-Bug: #1602390
Closes-Bug: #1602384
Fixed issue in initializing version variable and openstack node
variable, causing storage setup to abort.

Change-Id: I84b2f4764208d524f774601ed3e6356357ac8280