nova does not clean-up the second ephemeral disk when deleting an instance

[Nolwenn Cauchois]

Description

A second ephemeral disk to be considered as an image, then the backing file is not deleted when it is anymore not used.
After some instance create/delete period, the hypervisor local storage capacities are reduced ... and will decrease and decrease.

Actual result on mitaka :

- boot an instance with a flavor with an ephemeral disk
- on the hypervisor, two backing files were created in $instances_path/_base. One for the image and an other one for the ephemeral disk
- delete of the previous instance
- if remove_unused_base_images = True, then after a while the backing file for image is deleted (if it's not used by another instance), but not the backing file for ephemeral disk

Expected result :

If it's not used by another instance, the backing file for ephemeral disk must be also deleted.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/341008

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/341008
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.

[Sean Dague (sdague)]

Automatically discovered version mitaka in description. If this is incorrect, please update the description to include 'nova version: ...'

[Sean Dague (sdague)]

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

[Sean Dague (sdague)]

I restored the old patch, it seems to have been abandoned prematurely.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Stephen Finucane (<email address hidden>) on branch: master
Review: https://review.openstack.org/341008
Reason: This has been here for some time with no updates. Abandoning to clean up the review queue

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/689422

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 23.0.0.0rc1 release candidate.