LVM Snapshot can't be deleted if backend lv is inactive

[Nate Potter]

This seems like it's likely an issue for any driver rather than just LVM, but I have LVM enabled. I created a volume and snapshot, and then ended up manually deleting the snap with lv commands so that cinder didn't know about it. Then when trying to delete the snapshot with Cinder using the force param, it's impossible to remove the entry from Cinder's DB, because if a VolumeBackendApiException is raised when the snapshot isn't found, all that's done is set the snapshot's status to error_deleting. I think it might be useful to create a new exception for not finding the intended snapshot in the backend, and allow Cinder to delete it from the DB in this case.

[Nate Potter (ntpttr)]

After looking into this a little more, it seems that the problem isn't if the snapshot has been deleted with lvremove, it's when the snapshot is inactive. In this paste I deactivate the source volume for the snap, display both showing that it's inactive and not available, and then try to delete it.

http://paste.openstack.org/show/531020/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/341808

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/341808
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Sean McGinnis (sean-mcginnis)]

Unassigning due to no activity for > 6 months.