trusty: ceph-osd , ceph-mon charms : upgrading to Jewel doesn't work

[Aymen Frikha]

Trusty charms: ceph-mon and ceph-osd

Upgrading to cloud:trusty-liberty works fine. But upgrading to cloud:trusty-mitaka doesn't work.

2016-07-07 15:37:33.324639 7effc9f104c0 -1 error opening mon data directory at '/var/lib/ceph/mon/ceph-juju-machine-2-lxc-1': (22) Invalid argument
IO error: /var/lib/ceph/mon/ceph-juju-machine-2-lxc-1/store.db/LOCK: Permission denied

 2016-07-07 15:37:33.386223 7fef1b1934c0 -1 error opening mon data directory at '/var/lib/ceph/mon/ceph-juju-machine-2-lxc-1': (22) Invalid argument
IO error: /var/lib/ceph/mon/ceph-juju-machine-2-lxc-1/store.db/LOCK: Permission denied

It seems that is related : the default user changes from root -> ceph in the newer versions

[Chris Holcombe (xfactor973)]

Yeah when the user changes during the upgrade path from root to ceph this breaks the newer ceph versions. The upgrader needs to check the version and chown as needed

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/345647
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-osd/commit/?id=3e465ba4f8e3522a27c20dc74d93f5cb5a57984b
Submitter: Jenkins
Branch: master

commit 3e465ba4f8e3522a27c20dc74d93f5cb5a57984b
Author: Chris Holcombe <email address hidden>
Date: Thu Jul 21 13:10:14 2016 -0700

    Fix directory ownership as part of upgrade

    This change ensures that when ceph is upgraded from an
    older version that uses root to a newer version that
    uses ceph as the process owner that all directories
    are chowned.

    Closes-Bug: 1600338
    Change-Id: Ifac8cde6e6ea6f3a366fb40b9ffd261036720310

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/345646
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-mon/commit/?id=be87bd11b46bb80b52552d04110a432ca49109e8
Submitter: Jenkins
Branch: master

commit be87bd11b46bb80b52552d04110a432ca49109e8
Author: Chris Holcombe <email address hidden>
Date: Thu Jul 21 13:08:14 2016 -0700

    Fix directory ownership as part of upgrade

    This change ensures that when ceph is upgraded from an
    older version that uses root to a newer version that
    uses ceph as the process owner that all directories
    are chowned.

    Closes-Bug: 1600338
    Change-Id: I162ebdbeee0d7bae4866b6462f98f11e3892b7ba

[James Page (james-page)]

This really needs to be applied into ceph as well.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/16.07
Review: https://review.openstack.org/353370

[James Page (james-page)]

Also the ceph charm needs to deal with potentially restarting osd's as well, as the charm supports both mon and osd daemons.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/353368
Committed: https://git.openstack.org/cgit/openstack/charm-ceph/commit/?id=001d890d426e86d15f7138eb243126d05b0bfa91
Submitter: Jenkins
Branch: master

commit 001d890d426e86d15f7138eb243126d05b0bfa91
Author: James Page <email address hidden>
Date: Wed Aug 10 11:24:30 2016 +0100

    Fix directory ownership as part of upgrade and restart OSD's

    This change ensures that when ceph is upgraded from an
    older version that uses root to a newer version that
    uses ceph as the process owner that all directories
    are chowned.

    As the ceph charm can also host OSD processes, ensure that
    any ceph-osd daemons are stopped and started during the
    upgrade process.

    Change-Id: Ief3fd6352b440b7740965746cd0d1d846c647f84
    Closes-Bug: 1600338

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/353370
Committed: https://git.openstack.org/cgit/openstack/charm-ceph/commit/?id=7f073d19b5f1f89318dc7267cf237bb3376ae6db
Submitter: Jenkins
Branch: stable/16.07

commit 7f073d19b5f1f89318dc7267cf237bb3376ae6db
Author: James Page <email address hidden>
Date: Wed Aug 10 11:24:30 2016 +0100

    Fix directory ownership as part of upgrade and restart OSD's

    This change ensures that when ceph is upgraded from an
    older version that uses root to a newer version that
    uses ceph as the process owner that all directories
    are chowned.

    As the ceph charm can also host OSD processes, ensure that
    any ceph-osd daemons are stopped and started during the
    upgrade process.

    Change-Id: Ief3fd6352b440b7740965746cd0d1d846c647f84
    Closes-Bug: 1600338
    (cherry picked from commit 001d890d426e86d15f7138eb243126d05b0bfa91)