Can not remove the non-empty nodes of k8sbay

Bug #1600125 reported by PanFengyun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
In Progress
Medium
PanFengyun

Bug Description

1. Magnum use the get_removal_nodes() of scale_manager.py to get the nodes which need to be removed, but the get_removal_nodes() can not get the nodes which has pods or containers.
So Magnum just remove the nodes which has not pods or containers.

2. I get "Magnum can remove the nodes which has pods or containers" from the following URL:
http://docs.openstack.org/developer/magnum/dev/dev-quickstart.html
----
If you choose to reduce the node_count, magnum will first try to remove empty nodes with no pods running on them. If you reduce node_count by more than the number of empty nodes, magnum must remove nodes that have running pods on them. This action will delete those pods. We strongly recommend using a replication controller before reducing the node_count so any removed pods can be automatically recovered on your remaining nodes.
----

1 is conflict to 2.

Is the get_removal_nodes() of scale_manager.py wrong? or...

Should we let get_removal_nodes() get nodes without checking pods?

description: updated
Changed in magnum:
assignee: nobody → PanFengyun (pan-feng-yun)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/343311

Changed in magnum:
status: New → In Progress
Eli Qiao (taget-9)
Changed in magnum:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to magnum (master)

Reviewed: https://review.openstack.org/345834
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=7a5cd248cb8740dfbed68364bf8f3f7bc87dc102
Submitter: Jenkins
Branch: master

commit 7a5cd248cb8740dfbed68364bf8f3f7bc87dc102
Author: Eli Qiao <email address hidden>
Date: Fri Jul 22 14:25:07 2016 +0800

    Pass private ip address to scale manager

    In scale manager, we get host ip address from COEs, these ip address are
    all private ip address, so passing a private ip address of host of nodes
    to scale manager to let it decide which nodes to be removed.

    Related-Bug: #1600125
    Change-Id: I1a396f55b564f1b3ca59d5f73d264ef0eb948201

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on magnum (master)

Change abandoned by Adrian Otto (<email address hidden>) on branch: master
Review: https://review.openstack.org/343311
Reason: Marking this as abandoned due to >30 days of inactivity. You are welcome to un-abandon this and submit a revision, but it's too stale for reviewers to consider it for merge.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/403427

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on magnum (master)

Change abandoned by PanFengyun (<email address hidden>) on branch: master
Review: https://review.openstack.org/343311

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/403436

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on magnum (master)

Change abandoned by Adrian Otto (<email address hidden>) on branch: master
Review: https://review.openstack.org/403436
Reason: This patch has been in merge conflict for a month with no update. you are welcome to revisit this patch by un-abandoning it, and posting a revision to resolve the conflict.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Feilong Wang (<email address hidden>) on branch: master
Review: https://review.opendev.org/403427
Reason: Hi, I'm going to abandon this by doing an overall project cleanup. Please feel free to reopen this. Thanks.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.