tripleo

failed update and/or upgrade attempt should return non 0 value.

Bug #1599872 reported by Alexander Chuzhoy on 2016-07-07

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	High	Brad P. Crochet	tripleo newton-rc1 "newton-rc1"

Bug Description

Currently , once the update or upgrade fails:
IN_PROGRESS
FAILED
update finished with status FAILED

The exit value is 0, so we can't test result based on it.

Expected:
The exit value should be 0 only when the update/upgrade succeeded.

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-07: Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/339048

Changed in tripleo:
assignee:	nobody → Brad P. Crochet (brad-9)
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-07-14

Changed in tripleo:
importance:	Undecided → High
milestone:	none → newton-3

Steven Hardy (shardy) on 2016-08-31

tags:	added: tripleoclient
Changed in tripleo:
milestone:	newton-3 → newton-rc1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-12: Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/339048
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=7f832fb3b2ac95eb202ba45742a95c21a7056efc
Submitter: Jenkins
Branch: master

commit 7f832fb3b2ac95eb202ba45742a95c21a7056efc
Author: Brad P. Crochet <email address hidden>
Date: Thu Jul 7 11:00:01 2016 -0400

Throw an error/exception when interactive overcloud update fails

    The overcloud update currently returns an exit code of 0 regardless
    of the outcome of the update. Unless the result is COMPLETE,
    the client now throws an exception, and therefore a non-0 RC.

Also, change the unit tests to use 'COMPLETE' and not 'UPDATE_COMPLETE'
since Heat returns status as 'COMPLETE'.

Change-Id: Ib4aa7982718fda7c3b5fc4e5ea7501203c69bb98
Closes-Bug: 1599872

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-15: Fix proposed to python-tripleoclient (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/370742

Julie Pichon (jpichon) on 2016-09-20

tags:

added: newton-backport-potential

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-20: Fix merged to python-tripleoclient (stable/newton)

Reviewed: https://review.openstack.org/370742
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=19eaf84dfdcafaf0b927cb8d0710a5935cf08842
Submitter: Jenkins
Branch: stable/newton

commit 19eaf84dfdcafaf0b927cb8d0710a5935cf08842
Author: Brad P. Crochet <email address hidden>
Date: Thu Jul 7 11:00:01 2016 -0400

Throw an error/exception when interactive overcloud update fails

    The overcloud update currently returns an exit code of 0 regardless
    of the outcome of the update. Unless the result is COMPLETE,
    the client now throws an exception, and therefore a non-0 RC.

Also, change the unit tests to use 'COMPLETE' and not 'UPDATE_COMPLETE'
since Heat returns status as 'COMPLETE'.

    Change-Id: Ib4aa7982718fda7c3b5fc4e5ea7501203c69bb98
    Closes-Bug: 1599872
    (cherry picked from commit 7f832fb3b2ac95eb202ba45742a95c21a7056efc)