openstackbmc still failing with concatenation errors

[Ben Nemec]

I believe Derek fixed this in upstream pyghmi, but it doesn't look like it's been released yet. We may want to pre-install the git versions on the BMC images to avoid the problem. We should also request a release of pyghmi.

Note that this is probably responsible for a lot of the spurious failures in CI that I have looked at.

Pyghmi commit: https://github.com/openstack/pyghmi/commit/98798b2372b9db06632d54ad1ba32ba6181f51f2

Stack trace in bmc logs:
[177420.948694] openstackbmc[2379]: Traceback (most recent call last):
[177420.950266] openstackbmc[2379]: File "/usr/local/bin/openstackbmc", line 170, in <module>
[177420.951304] openstackbmc[2379]: mybmc.listen()
[177420.952029] openstackbmc[2379]: File "/usr/lib/python2.7/site-packages/pyghmi/ipmi/bmc.py", line 147, in listen
[177420.953202] openstackbmc[2379]: ipmisession.Session.wait_for_rsp(timeout)
[177420.954119] openstackbmc[2379]: File "/usr/lib/python2.7/site-packages/pyghmi/ipmi/private/session.py", line 1069, in wait_for_rsp
[177420.955425] openstackbmc[2379]: relsession.process_pktqueue()
[177420.956250] openstackbmc[2379]: File "/usr/lib/python2.7/site-packages/pyghmi/ipmi/private/session.py", line 1158, in process_pktqueue
[177420.957571] openstackbmc[2379]: self._handle_ipmi_packet(pkt[0], sockaddr=pkt[1])
[177420.958536] openstackbmc[2379]: File "/usr/lib/python2.7/site-packages/pyghmi/ipmi/private/session.py", line 1214, in _handle_ipmi_packet
[177420.960411] openstackbmc[2379]: self._handle_ipmi2_packet(data)
[177420.961263] openstackbmc[2379]: File "/usr/lib/python2.7/site-packages/pyghmi/ipmi/private/session.py", line 1285, in _handle_ipmi2_packet
[177420.962615] openstackbmc[2379]: self._parse_ipmi_payload(payload)
[177420.963473] openstackbmc[2379]: File "/usr/lib/python2.7/site-packages/pyghmi/ipmi/private/session.py", line 1474, in _parse_ipmi_payload
[177420.964814] openstackbmc[2379]: self._parse_payload(payload)
[177420.965646] openstackbmc[2379]: File "/usr/lib/python2.7/site-packages/pyghmi/ipmi/private/session.py", line 1537, in _parse_payload
[177420.966970] openstackbmc[2379]: self.ipmicallback(response)
[177420.967778] openstackbmc[2379]: File "/usr/lib/python2.7/site-packages/pyghmi/ipmi/private/serversession.py", line 183, in handle_client_request
[177420.969190] openstackbmc[2379]: self.bmc.handle_raw_request(request, self)
[177420.970109] openstackbmc[2379]: File "/usr/lib/python2.7/site-packages/pyghmi/ipmi/bmc.py", line 141, in handle_raw_request
[177420.971824] openstackbmc[2379]: session._send_ipmi_net_payload(code=0xff)
[177420.972743] openstackbmc[2379]: File "/usr/lib/python2.7/site-packages/pyghmi/ipmi/private/session.py", line 720, in _send_ipmi_net_payload
[177420.974125] openstackbmc[2379]: data = [code] + data
[177420.974878] openstackbmc[2379]: TypeError: can only concatenate list (not "tuple") to list

[Derek Higgins (derekh)]

I had only noticed this in a large OVB deployment, but its worth a try. I've patched the bmc-template image on rh2 to use this. @ben Do you know who to ask about a release so it just works next time we generate an image?

[Ben Nemec (bnemec)]

I pulled the trace above from one of the testenv bmcs, so it's definitely happening in the smaller environments too. I haven't seen any today though, so applying the patch appears to have worked.

The person to talk to about a release is Jarrod Johnson. I believe there's a pyghmi bug tracker on LP now, so I'll add it to this bug and hopefully that will do the trick.

[Emilien Macchi (emilienm)]

This bug was last updated over 180 days ago, as tripleo is a fast moving project and we'd like to get the tracker down to currently actionable bugs, this is getting marked as Invalid. If the issue still exists, please feel free to reopen it.

[Ben Nemec (bnemec)]

This is actually fixed.