[Liberty] Minor updates updates might fail with missing MysqlClustercheckPassword property

[Michele Baldessari]

With the fixes for the galera root password:
- python-tripleoclient: https://review.openstack.org/317542
- tripleo-heat-template: https://review.openstack.org/316297

we added the MysqlClustercheckPassword property which sets the password for
the clustercheck user. If a user runs a minor update via "openstack overcloud
update" this the code for python-tripleoclient adding the password to the
overcloudrc password file will not be triggered, and the user will get the
following error:

    Property error: resources[1].properties: Property MysqlClustercheckPassword not assigned

Since the process of fixing the galera root password requires a full deploy command
anyway, it is okay to give the MysqlClustercheckPassword property a default empty value.
It will not be set anyway during a minor update.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/337304

[Giulio Fidente (gfidente)]

The reason why we opted for a default in the template is that by making the client update the passwords file on update can cause more damages unless it is run from the same directory where the passwords file was generated initially... if it's not, it will re-create (and change) all passwords.

[Marios Andreou (marios-b)]

for more context, this bug is discussed at https://bugzilla.redhat.com/show_bug.cgi?id=1344794 and https://bugzilla.redhat.com/show_bug.cgi?id=1353019

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/343253

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/343253
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=758fa37bbd2d110f68f6dc54887d8245db9a5bc0
Submitter: Jenkins
Branch: stable/mitaka

commit 758fa37bbd2d110f68f6dc54887d8245db9a5bc0
Author: Michele Baldessari <email address hidden>
Date: Sun Jul 17 08:35:45 2016 +0200

    Minor updates might fail with missing MysqlClustercheckPassword property

    With the fixes for the galera root password:
    - python-tripleoclient: https://review.openstack.org/317542
    - tripleo-heat-template: https://review.openstack.org/316297

    we added the MysqlClustercheckPassword property which sets the password
    for the clustercheck user. When a user runs a minor update via "openstack
    overcloud update" he will get the following error:

        Property error: resources[1].properties: Property MysqlClustercheckPassword not assigned

    This happens because the new property does not yet have a set value.
    This new property is not set unless we do an "overcloud deploy", because
    the tripleoclient code generating the passwords does not get invoked
    during a minor update.

    We want to make sure that it has a value set. It is not used during a
    minor update in any case but heat does require it.

    Since the process of fixing the galera root password requires a full
    overcloud deploy command anyway, it is okay to give the
    MysqlClustercheckPassword property a default empty value. Upgrades are
    not affected because they do run a a full overcloud deploy command.

    Closes-bug: #1598890

    Change-Id: I4ab82e6fba08279b96e84c48e223262f656f1120

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/337304
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=8cd91054fbfd4223f1bca949180a26ced0614373
Submitter: Jenkins
Branch: stable/liberty

commit 8cd91054fbfd4223f1bca949180a26ced0614373
Author: Michele Baldessari <email address hidden>
Date: Mon Jul 4 18:09:19 2016 +0200

    Minor updates might fail with missing MysqlClustercheckPassword property

    With the fixes for the galera root password:
    - python-tripleoclient: https://review.openstack.org/317542
    - tripleo-heat-template: https://review.openstack.org/316297

    we added the MysqlClustercheckPassword property which sets the password
    for the clustercheck user. When a user runs a minor update via "openstack
    overcloud update" he will get the following error:

        Property error: resources[1].properties: Property MysqlClustercheckPassword not assigned

    This happens because the new property does not yet have a set value.
    This new property is not set unless we do an "overcloud deploy", because
    the tripleoclient code generating the passwords does not get invoked
    during a minor update.

    We want to make sure that it has a value set. It is not used during a
    minor update in any case but heat does require it.

    Since the process of fixing the galera root password requires a full
    overcloud deploy command anyway, it is okay to give the
    MysqlClustercheckPassword property a default empty value. Upgrades are
    not affected because they do run a a full overcloud deploy command.

    Closes-bug: #1598890

    Change-Id: I4ab82e6fba08279b96e84c48e223262f656f1120

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/tripleo-heat-templates 2.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 2.1.0 release.

[Emilien Macchi (emilienm)]

This bug was last updated over 180 days ago, as tripleo is a fast moving project and we'd like to get the tracker down to currently actionable bugs, this is getting marked as Invalid. If the issue still exists, please feel free to reopen it.