Performance issues with keystone under wsgi apache on a multinode machine

[Marios Andreou]

As first discussed at https://bugzilla.redhat.com/show_bug.cgi?id=1347305 since we now run keystone under wsgi::apache, deploying on a multinode host gives very poor performance, because the current default for puppet-keystone is to have 1 worker [1] and ::processorcount threads [2].

We should be able to set both of these as parameters, as jistr points out in the BZ keystone::wsgi::apache::workers and keystone::wsgi::apache::threads.

Since keystone under wsgi is a mitaka thing we will also need to backport this. However, the backport is going to be significantly different because master has composable keystone service whereas mitaka doesn't.

Review for master incoming momentarily thanks.

[1] https://github.com/openstack/puppet-keystone/blob/e812075fd9ed7c0754e00adaf74db6eeaf403bc1/manifests/wsgi/apache.pp#L168
[2] https://github.com/openstack/puppet-keystone/blob/e812075fd9ed7c0754e00adaf74db6eeaf403bc1/manifests/wsgi/apache.pp#L176

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/336472

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/336520

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/336472
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=dd41e052eaf4e86f20461fd6529b4c4899b8544f
Submitter: Jenkins
Branch: master

commit dd41e052eaf4e86f20461fd6529b4c4899b8544f
Author: marios <email address hidden>
Date: Fri Jul 1 13:01:08 2016 +0300

    Repurpose KeystoneWorkers add keystone::wsgi::apache::threads

    Now that keystone is run with wsgi apache the KeystoneWorkers
    param has no efffect [1]. This repurposes KeystoneWorkers to now
    set wsgi::apache::workers and adds the
    keystone::wsgi::apache::threads hardcoding to 1 (can overrride
    via extraconfig data)

    [1] https://github.com/openstack/puppet-keystone/blob/51c68fb127c28b9748b352871783c3ec6ef5c83b/manifests/init.pp#L396

    Closes-Bug: 1598092
    Change-Id: I503d1f0d3f4c56abfaf4609ea8290e78668013b6

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/336520
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3e658b6e1a84f442fce53731d60319388f88fc11
Submitter: Jenkins
Branch: stable/mitaka

commit 3e658b6e1a84f442fce53731d60319388f88fc11
Author: marios <email address hidden>
Date: Fri Jul 1 14:35:25 2016 +0300

    Repurpose KeystoneWorkers add keystone::wsgi::apache::threads

    Now that keystone is run with wsgi apache the KeystoneWorkers
    param has no efffect [1]. This repurposes KeystoneWorkers to
    now set wsgi::apache::workers and adds the
    keystone::wsgi::apache::threads hardcoding to 1 in controller
    hieradata.

    In master at https://review.openstack.org/#/c/336472/

    [1] https://github.com/openstack/puppet-keystone/blob/51c68fb127c28b9748b352871783c3ec6ef5c83b/manifests/init.pp#L396

    Closes-Bug: 1598092
    Change-Id: Ife898e83efc523e5258dc32a578813acf4fee3fa

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/tripleo-heat-templates 2.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 2.1.0 release.