OS::Heat::ScalingPolicy does not consider any Alarm but alarm status

[Federico Iezzi]

Hello there,

The Resource OS::Heat::ScalingPolicy consider the Ceilometer Alarm only if those are in "Alarm" status.
It means that e.g. "insufficient_data_actions" will never be taken into consideration by Heat.

Below the related code:
https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/heat/scaling_policy.py#L163

As a cloud user I would like to define specific Ceilometer Rules and have the freedom to perform any action I want at any specific signal/status.

This bug is present into the code since has been merged the OS::Heat::ScalingPolicy
https://github.com/openstack/heat/blob/ac2844f8bf8f427abb8eaef058be6d725da9f697/heat/engine/resources/openstack/heat/scaling_policy.py#L131

[Rabi Mishra (rabi)]

I think the docstring mentioned that it can be used with any alarm notifier[1]. So the check should be removed.

[1] https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/heat/scaling_policy.py#L149-L151

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/338703

[Federico Iezzi (fiezzi)]

Hi there,

Is it possible to propose a patch also for Mitaka and would be wonderful also for Liberty?

Thanks!

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/338703
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=fe4f250826b16f260cf71687ac6c99f65bb1f295
Submitter: Jenkins
Branch: master

commit fe4f250826b16f260cf71687ac6c99f65bb1f295
Author: rabi <email address hidden>
Date: Thu Jul 7 09:46:32 2016 +0530

    Don't check alarm state when signaled

    Scaling policies(alarm_url) are normally expected to be
    used with 'alarm_actions' of Alarm resource plugins by
    the template author. However, we should not check for the
    alarm state before proceeding on handling the signal.
    This would provide flexibility to use these policies with
    other alarm actions like 'insufficient_data_actions',
    if required.

    Change-Id: I733f986c9ac151f76aa997d26e9b9cf8afd9f6c9
    Closes-Bug: #1598044

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 7.0.0.0b3 development milestone.