mistral client can not get mistral url correctly with haproxy configuration

[Spencer Yu]

The haproxy configuration is:

echo "#add for mistral_api8989" >> /etc/haproxy/haproxy.cfg
echo "frontend mistral_api8989-fe ${CONTROLLER_FE_IP}:8989" >> /etc/haproxy/haproxy.cfg
echo " default_backend mistral_api8989-be " >> /etc/haproxy/haproxy.cfg
echo "backend mistral_api8989-be" >> /etc/haproxy/haproxy.cfg
echo " balance roundrobin" >> /etc/haproxy/haproxy.cfg
echo " server ${CONTROLLER01_NAME} ${CONTROLLER01_IP}:8989 check " >> /etc/haproxy/haproxy.cfg
echo " server ${CONTROLLER02_NAME} ${CONTROLLER02_IP}:8989 check " >> /etc/haproxy/haproxy.cfg
echo "" >> /etc/haproxy/haproxy.cfg

The command "netstat -nultp| grep 8989" shows:

tcp 0 0 172.16.6.121:8989 0.0.0.0:* LISTEN 21316/python
tcp 0 0 172.16.6.120:8989 0.0.0.0:* LISTEN 190522/haproxy

when I use mistral dashboard, there is an error in /var/log/httpd/error_log:

Recoverable error: HTTPConnectionPool(host='localhost', port=8989): Max retries exceeded with url: /v2/workflows (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7fbbc80b3710>: Failed to establish a new connection: [Errno 111] Connection refused',))

It shows that the host to be listened is still localhost,that's not correct.

After debugging,I find that the problem is in mistralclient/api/v2/client.py:
In __init__ function:

    if not mistral_url:
        mistral_url = "http://localhost:8989/v2"

In authenticate function:

    if not mistral_url:
            catalog = keystone.service_catalog.get_endpoints(
                service_type=service_type,
                endpoint_type=endpoint_type
            )
            if service_type in catalog:
                service = catalog.get(service_type)
                mistral_url = service[0].get(
                    endpoint_type) if service else None

        return mistral_url, token, project_id, user_id

The problem is "mistral_url = service[0].get(endpoint_type) if service else None" can not get mistral_url,so mistral_url is still "http://localhost:8989/v2"

The reason is endpoint_type is "publicURL",but in service[0],it is not exist.

I find that publicURL of endpoint is used by old version of keystone,in Mitaka,keystone uses interface public and url instead of publicURL.

[Jeremy Liu (liujiong)]

Great catch!

[Lucky samadhiya (lucky-samadhiya)]

This bugs seems to be fixed in latest code

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/364204

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/364267

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/364204
Committed: https://git.openstack.org/cgit/openstack/python-mistralclient/commit/?id=b9e87ef8633e29a7777bd061ba810756d4e48863
Submitter: Jenkins
Branch: master

commit b9e87ef8633e29a7777bd061ba810756d4e48863
Author: Nikolay Mahotkin <email address hidden>
Date: Thu Sep 1 12:50:27 2016 +0300

    Fixing getting mistral_url from keystone catalog

    Closes-Bug: #1598018

    Depends-On: I1b61bd1de6811a5f65c2375dde956aafe33445b2
    Change-Id: I16f1a5ff412d98371dfaab863cb24b47438d2d1e

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/364267
Committed: https://git.openstack.org/cgit/openstack/python-mistralclient/commit/?id=f730dab1afb67e1dad63a55d6477514f097ef2cd
Submitter: Jenkins
Branch: stable/mitaka

commit f730dab1afb67e1dad63a55d6477514f097ef2cd
Author: Nikolay Mahotkin <email address hidden>
Date: Thu Sep 1 12:50:27 2016 +0300

    Fixing getting mistral_url from keystone catalog

    Closes-Bug: #1598018

    Change-Id: I16f1a5ff412d98371dfaab863cb24b47438d2d1e

[OpenStack Infra (hudson-openstack)]

Change abandoned by Spencer Yu (<email address hidden>) on branch: master
Review: https://review.openstack.org/336412

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-mistralclient 3.0.0 release.