Angular fall-through redirection doesn't use WEBROOT

Bug #1597823 reported by Matt Borland
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Matt Borland

Bug Description

When on an Angular page and using the fall-through routing (routing from an Angular page back to a Django page using Angular relative paths), the redirect doesn't respect WEBROOT.

This is best seen when using relative links in URLs, like in Searchlight panels and linking to internal pages, only when WEBROOT is other than '/'.

Tags: angularjs
Matt Borland (palecrow)
tags: added: angularjs
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/336107

Changed in horizon:
assignee: nobody → Matt Borland (palecrow)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/336107
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=eb60a8b2874a348fec104672ce7d5d991faa3d47
Submitter: Jenkins
Branch: master

commit eb60a8b2874a348fec104672ce7d5d991faa3d47
Author: Matt Borland <email address hidden>
Date: Thu Jun 30 10:17:46 2016 -0600

    Use absUrl, so WEBROOT isn't ignored on redirect

    For the 'fall-through' condition for Angular routing, it will
    simply redirect to the URL wanted. Basically, Angular says: "If
    I don't know this URL in my internal routing, it's outside the
    single-page-app and needs to be pulled from the server." However,
    the code uses the general Angular path, which does NOT include
    the base tag's prefix, meaning in a situation where WEBROOT is set
    to other than '/' it will not include the base value, and route to
    a non-WEBROOTed path. Using absUrl correctly uses the full path.

    Change-Id: Idbf91bd5913937788bf31bcf1d389c590dd3e2d7
    Closes-Bug: 1597823

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 10.0.0.0b2

This issue was fixed in the openstack/horizon 10.0.0.0b2 development milestone.

Changed in horizon:
importance: Undecided → High
milestone: none → newton-2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.