Containers/Swift URL Redirection Loop

[Diana Whitten]

If you hit /project/containers/container/ directly, you hit an infinite reloading loop.

See the captured animated gif attached.

[Travis Tripp (travis-tripp)]

For the above running under devstack dashboard webroot, i see the following:

http://<>/dashboard/project/containers/container/

flashes briefly
I get redirected to http://<>/project/containers/container/

With a 404 error.

This seems to happen for all django routed detail pages. Other examples:

/dashboard/project/networks/<ID>/detail

[Itxaka Serrano (itxaka)]

Can reproduce the container part but not in other detail pages, in those I get a 404.

This seems to be an issue between the "real" url and the url that we manage on the ContainersController

If you access project/containers you can see that the containerRoute attribute in the ContainersController is "project/containers/container/" so the angular route seems to catch up and try to redirect, entering an infinite loop:

Location change from http://localhost:8000/project/containers/container/ to http://localhost:8000/project/containers/container/

Checked this by adding the following to debug the route in case someone with more experience in angular wants to try to fix this:

--- a/openstack_dashboard/dashboards/project/static/dashboard/project/containers/containers.module.js
+++ b/openstack_dashboard/dashboards/project/static/dashboard/project/containers/containers.module.js
@@ -27,7 +27,21 @@
    */
   angular
     .module('horizon.dashboard.project.containers', ['ngRoute'])
- .config(config);
+ .config(config)
+ .run([
+ '$rootScope',
+ function($rootScope) {
+ $rootScope.$on('$routeChangeStart', function(event, next, current) {
+ var currentPath = current.originalPath;
+ var nextPath = next.originalPath;
+ console.log('Route change from %s to %s', currentPath, nextPath);
+ });
+ $rootScope.$on('$locationChangeStart', function(event, newUrl, oldUrl) {
+ // this is for redirects
+ console.log('Location change from %s to %s', oldUrl, newUrl);
+ });
+ }
+ ]);

   config.$inject = [
     '$provide',

[Matt Borland (palecrow)]

There are two separate issues here, let's not conflate them.

1) The original bug: containers doesn't route properly due to some confusion in the path.
2) Routing from Angular pages in a webroot context to non-Angular pages can cause bad redirect.

I will put a patch up for (2), separate from this bug report.

[Matt Borland (palecrow)]

FYI I believe the answer to (1) is due to

url(r'^container/((?P<container_name>.+?)/)?'

in containers' urls.py...this matches things oddly I believe when you have a container named 'container.'

[Matt Borland (palecrow)]

Finally, (2) is reported by: https://bugs.launchpad.net/horizon/+bug/1597823
and solved by: https://review.openstack.org/#/c/336107/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/336363

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/336363
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=399968528850814b7415a7cef9d031f4eb73ad6e
Submitter: Jenkins
Branch: master

commit 399968528850814b7415a7cef9d031f4eb73ad6e
Author: Richard Jones <email address hidden>
Date: Fri Jul 1 14:25:47 2016 +1000

    Fix constant redirect on missing container name

    The routing rules were missing a handler for the absence
    of the container name in the /project/containers/container/
    URL form. This caused AngularJS to issue a redirect when
    the container name is empty.

    Change-Id: I053934917ecfaa10dc8d760cc3a0d02249977031
    Closes-Bug: 1597528

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/horizon 10.0.0.0b2 development milestone.