TabbedTable redirection is broken in Horizon after switch to Django 1.9

Bug #1597353 reported by Timur Sufiev
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Confirmed
Low
Unassigned

Bug Description

Horizon uses URL query for specifying which tab in a tabbed table should be visible, see https://github.com/openstack/horizon/blob/10.0.0.0b1/openstack_dashboard/dashboards/project/volumes/urls.py#L30-L36

This worked until Django 1.9 came in. Now `reverse()` on such URLs escapes the '?' sign (a query part delimiter), which leads to TabbedTables always opening on first tab and URL redirection not working.

While obviously we have to invent a better solution, in the meantime it would be better to change integration tests expectations which fail due to the proper tab not opening in some scenarios.

Timur Sufiev (tsufiev-x)
tags: added: integration-tests
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to horizon (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/335518

Changed in horizon:
assignee: nobody → Rob Cresswell (robcresswell)
milestone: none → newton-2
importance: Undecided → High
Changed in horizon:
milestone: newton-2 → newton-3
Changed in horizon:
milestone: newton-3 → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Timur Sufiev (<email address hidden>) on branch: master
Review: https://review.openstack.org/335518

Changed in horizon:
assignee: Rob Cresswell (robcresswell) → nobody
status: New → Confirmed
milestone: next → pike-1
Changed in horizon:
milestone: pike-1 → pike-2
Changed in horizon:
milestone: pike-2 → pike-3
Changed in horizon:
milestone: pike-3 → pike-rc1
Changed in horizon:
milestone: pike-rc1 → next
Revision history for this message
Ying Zuo (yingzuo) wrote :

The gate check for integration tests has been disabled and we are not maintaining the integration tests.

Changed in horizon:
importance: High → Low
milestone: next → none
Akihiro Motoki (amotoki)
tags: removed: integration-tests
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.