Environment's region parameter is set to None in ui

Bug #1596964 reported by SFilatov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
SFilatov

Bug Description

Murano core-library's Environment class has parameter "region" and it could be set with cli. Though working in muranodashboard there's no way to set it explicitly and it is set to None. This causes issues in multiregion openstack setups.
I suggest we set region parameter to user's current region to resolve this.

Revision history for this message
Victor Ryzhenkin (vryzhenkin) wrote :

We are tested this feature in mitaka devstack. Did your environments configured correctly? You shouldn't be able to set environment parameter 'region' directly. This setting applied automatically if you choosing requested region in Horizon (in the top of dashboard near tenant). So, if you are not able to select region, then your environment have to be reconfigured.

Changed in murano:
status: New → Incomplete
importance: Undecided → High
milestone: none → newton-2
assignee: nobody → SFilatov (filatecs)
Revision history for this message
SFilatov (sergeyfilatov) wrote :

I'm able to select region. Though it's set to None.
Besides, I don't see which part of muranodashboard code is setting region.
In my setup:
/usr/lib/python2.7/dist-packages/muranodashboard/environments/api.py:

def environment_create(request, parameters):
    # name is required param
    body = {'name': parameters['name']}
    if 'defaultNetworks' in parameters:
        body['defaultNetworks'] = parameters['defaultNetworks']
    env = api.muranoclient(request).environments.create(body)
    LOG.debug('Environment::Create {0}'.format(env))
    return env

Which I suppose should have region as one of parameters

Revision history for this message
Valerii Kovalchuk (vakovalchuk) wrote :

@SFilatov, are you saying about something like this? https://review.openstack.org/#/c/305747/

Revision history for this message
SFilatov (sergeyfilatov) wrote :

Yes, that'd solve this

Revision history for this message
Valerii Kovalchuk (vakovalchuk) wrote :

As you can see, this proposal was declined. You can see the discussion of that matter here: http://eavesdrop.openstack.org/meetings/murano/2016/murano.2016-04-19-17.01.log.html#l-31

Revision history for this message
Valerii Kovalchuk (vakovalchuk) wrote :

By the way, what issues did you mean this could cause?

Revision history for this message
SFilatov (sergeyfilatov) wrote :

I see the point. Though as @KZaitsev pointed out we can allow users to choose region as set default with selected one. Currently in my setup(fuel 9.0) I don't have home_region in murano.conf and was not aware if it.
Issue comes with using murano plugins: I have multidomain setup and there's no convenient way to extract current region inside the plugin, so there I'm getting endpoints for all the domains. I would really benefit from getting region value from environment class, it seems reasonable

Revision history for this message
Valerii Kovalchuk (vakovalchuk) wrote :

I can suggest you to add this topic to the next murano meeting: https://wiki.openstack.org/wiki/Meetings/MuranoAgenda
and to discuss it one more time

Changed in murano:
milestone: newton-2 → newton-3
Revision history for this message
Kirill Zaitsev (kzaitsev) wrote :
Changed in murano:
status: Incomplete → Fix Released
importance: High → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.