Delete port confirmation is missing port name or ID

[Brad Pokorny]

Steps to reproduce:

- This can be reproduced using the latest master code as of 6/27/16.

- Go to Admin -> System -> Networks -> select a network -> Ports tab -> Click on a Port to see the Details -> Click "Delete Port" (from Details)

The "Confirm Delete Port" text says:

"You have selected: . Please confirm your selection. This action cannot be undone."

So we are missing the port name or ID when running actions on Details screens.

This applies to other resources as well, such as Subnets.

[Rob Cresswell (robcresswell-deactivatedaccount)]

I couldn't recreate this. The only oddity I see is that if I go to delete a named port, it shows the ID in the delete message instead of the name, but thats it.

[Ankur (ankur-gupta-f)]

http://pasteboard.co/24IgRpOJ.png

[Ankur (ankur-gupta-f)]

Thats the message that pops up. Then when you confirm. It doesn't delete the port/subnet... etc...
which is the other bug

[Rob Cresswell (robcresswell-deactivatedaccount)]

Ah, I see! I didn't realise the Details page part. I interpreted click on it and click delete, as selecting and using the table row delete.

[Ankur (ankur-gupta-f)]

https://review.openstack.org/#/c/336662/

The horizon.tables.js change fixes this bug.
As well as this same issue in other resource deletions

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/336662
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=53bdad4cf7d6a2039c8de3bd41402824444d7837
Submitter: Jenkins
Branch: master

commit 53bdad4cf7d6a2039c8de3bd41402824444d7837
Author: Luis Daniel Castellanos <email address hidden>
Date: Fri Jul 1 11:49:35 2016 -0500

    Ability to delete network items from their details page

    This patch fixes the bug that was preventing users to delete a port
    from the Admin>Networks>Port Details page

    It also fixes bug preventing user from deleting a subnet from
    the Admin>Networks>Port Details page.

    The fix affects both Project>Networks & Admin>Networks

    Co-Authored-By: Ankur Gupta <email address hidden>

    Change-Id: I408f190584b01e0aadd1af2d4a59438a53426e70
    Closes-Bug: #1596411
    Closes-Bug: #1596691

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 10.0.0.0rc1 release candidate.