Libertine

libertine-container-manager crashes when log file not found

Bug #1596661 reported by Larry Price
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Libertine
Status tracked in Devel
Devel
Fix Released
Medium
Christopher Townsend
Libertine 1.3
Trunk
Fix Released
Medium
Christopher Townsend
Libertine 1.3
libertine (Ubuntu)
Fix Released
Medium
Christopher Townsend

Bug Description

If I have a "corrupt" container in my ContainersConfig.json, I only see a stack trace when I run any command requiring the container to start because the lxc log file cannot be found. Because of the exception, the ContainersConfig.json is not reverted on error.

Example ContainersConfig.json: https://paste.ubuntu.com/17986067/

Command with output: https://paste.ubuntu.com/17986092/

We should do a try-catch in the dump function and print out a generic error message such as "Unable to start container."

Similar to #1596020.

Related branches

lp:~townsend/libertine/fix-missing-log
Larry Price: Approve
Libertine CI Bot: Approve (continuous-integration)
Diff: 34 lines (+10/-3)
1 file modified
python/libertine/LxcContainer.py (+10/-3)
lp:~townsend/libertine/release-1.2.2
Larry Price: Approve
Diff: 2202 lines (+838/-865)
17 files modified
debian/changelog (+30/-0)
debian/python3-libertine.install (+2/-0)
debian/rules (+3/-0)
libertine/qml/ExtraArchivesView.qml (+3/-6)
libertine/qml/GenericErrorDialog.qml (+17/-3)
libertine/qml/HomeView.qml (+51/-43)
po/CMakeLists.txt (+0/-3)
python/libertine/ChrootContainer.py (+26/-72)
python/libertine/ContainersConfig.py (+309/-0)
python/libertine/HostInfo.py (+71/-0)
python/libertine/Libertine.py (+17/-44)
python/libertine/LxcContainer.py (+19/-16)
python/libertine/utils.py (+1/-29)
tests/unit/CMakeLists.txt (+11/-7)
tools/libertine-container-manager (+269/-634)
tools/libertine-launch (+8/-8)
tools/libertine-session-bridge (+1/-0)
Christopher Townsend (townsend)
Changed in libertine (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Libertine CI Bot (libertine-ci-bot) wrote :

Fix committed into lp:libertine at revision 261, scheduled for release in libertine, milestone Unknown

Changed in libertine:
status: In Progress → Fix Committed
Christopher Townsend (townsend)
Changed in libertine (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Christopher Townsend (townsend)
Christopher Townsend (townsend)
Changed in libertine (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.