OpenStack Dashboard (Horizon)

unitests fail with the presence of a local_settings file

Bug #1596466 reported by Yves-Gwenael Bourhis on 2016-06-27

This bug affects 3 people

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	High	Yves-Gwenael Bourhis	OpenStack Dashboard (Horizon) newton-2 "n2"

Bug Description

The following patch broke stable/mitaka and master unittests because the custom local_settings file is sourced and should not:

https://review.openstack.org/#/q/I05c8fc750c56f6f6bb49a435662e821eb0d6ba30,n,z

this is because we should have "from django.conf import settings" instead of "from openstack_dashboard import settings".

Tags:

Yves-Gwenael Bourhis (yves-gwenael-bourhis) on 2016-06-27

tags:	added: mitaka-backport-potential
summary:	- unitests fail whit the presence of a local_settings file + unitests fail with the presence of a local_settings file

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-06-27: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/334369

Changed in horizon:
assignee:	nobody → Yves-Gwenael Bourhis (yves-gwenael-bourhis)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-06-27: Fix proposed to horizon (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/334375

Rob Cresswell (robcresswell-deactivatedaccount) on 2016-06-27

Changed in horizon:
importance:	Undecided → High
milestone:	none → newton-2

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-06-27: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/334369
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=797f823c6ee3a8243996b5f9df08f4c5de2c4f07
Submitter: Jenkins
Branch: master

commit 797f823c6ee3a8243996b5f9df08f4c5de2c4f07
Author: Yves-Gwenael Bourhis <email address hidden>
Date: Mon Jun 27 11:30:21 2016 +0200

Never import setting from openstack_dashboard

    Unittests have their own settings and should not source openstack_dashboard
    settings.
    It is commonly known that django code should always import settings via
    "from django.conf import settings".

Change-Id: I4fb5f68ed9595c5f785437b863e2eef7f6ab23c1
Closes-Bug: #1596466

Changed in horizon:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-06-29: Fix merged to horizon (stable/mitaka)

Reviewed: https://review.openstack.org/334375
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=9b2b8e219794dc6a6aca967d455d7892ef468c2e
Submitter: Jenkins
Branch: stable/mitaka

commit 9b2b8e219794dc6a6aca967d455d7892ef468c2e
Author: Yves-Gwenael Bourhis <email address hidden>
Date: Mon Jun 27 11:30:21 2016 +0200

Never import setting from openstack_dashboard

    Change-Id: I4fb5f68ed9595c5f785437b863e2eef7f6ab23c1
    Closes-Bug: #1596466
    (cherry picked from commit 797f823c6ee3a8243996b5f9df08f4c5de2c4f07)