Uses legacy /v2/snapd?q= instead of /v2/find?q= API - caused many messages in log

Bug #1596378 reported by Jeremy Bícha
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-software (Ubuntu)
Fix Released
Low
Robert Ancell
Xenial
Fix Released
Low
Unassigned
Yakkety
Fix Released
Low
Robert Ancell

Bug Description

[Impact]
Using the old snapd search API causes messages to be written to the systemd log.

[Test Case]
1. Start GNOME Software
2. Search for some apps (e.g. "moon")
3. Check systemd journal with 'journalctl'

Expected result:
Results are shown, no significant logs written to systemd journal.

Observed result:
Many logs like this written:
Jun 26 18:55:43 /usr/lib/snapd/snapd[1085]: api.go:474: jumping to "find" to better support legacy request "/v2/snaps?q=wikipe
Jun 26 18:55:43 /usr/lib/snapd/snapd[1085]: api.go:393: DEBUG: use of obsolete "q" parameter: "/v2/snaps?q=wikipedia.org"
Jun 26 18:55:41 /usr/lib/snapd/snapd[1085]: daemon.go:181: DEBUG: uid=1000;@ GET /v2/snaps?q=wikipedia 170.9766ms 200

[Regression potential]
Low. We just use the new request name in snapd.

Revision history for this message
Jeremy Bícha (jbicha) wrote :
Revision history for this message
Robert Ancell (robert-ancell) wrote :

hmm, looks like snapd changed API...

summary: - snap plugin spams journal
+ Uses legacy /v2/snapd?q= instead of /v2/find?q= API - caused many
+ messages in log
Changed in gnome-software (Ubuntu):
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Robert Ancell (robert-ancell)
Revision history for this message
Jeremy Bícha (jbicha) wrote :

By the way, this is with snapd 2.0.9+16.10 from yakkety-proposed (where it's stuck) which I manually installed a while ago. I've rebooted since then.

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Looking at the snapd git branch the /v2/find API was added around 1.9.4 so it should be safe to switch over regardless. The warning seems to have been added around 2.0.3.

description: updated
Changed in gnome-software (Ubuntu Xenial):
status: New → Triaged
importance: Undecided → Medium
importance: Medium → Low
Changed in gnome-software (Ubuntu Yakkety):
importance: Medium → Low
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.20.1+git20160923.2.7374bdc-0ubuntu1

---------------
gnome-software (3.20.1+git20160923.2.7374bdc-0ubuntu1) yakkety; urgency=medium

  * New upstream snapshot from the wip/ubuntu branch at
    git://git.gnome.org/gnome-software.
    - Fix crash on 32 bit arch live images (LP: #1571729)
  * debian/README.source: Update branch name (wip/ubuntu-xenial -> wip/ubuntu).

gnome-software (3.20.1+git20160923.1.0c571f1-0ubuntu1) yakkety; urgency=medium

  * New upstream snapshot from the wip/ubuntu branch at
    git://git.gnome.org/gnome-software.
    - Fix failure refining first snap doesn't affect other snaps (LP: #1626803)
    - Support snap launching (LP: #1564076)
    - Don't prompt user to upgrade held packages (LP: #1573061)
    - Use /v2/find API instead of obsolete /v2/snaps API for searching (LP: #1596378)
    - Download changelog information on demand (LP: #1574666)

 -- Iain Lane <email address hidden> Fri, 23 Sep 2016 18:21:37 +0100

Changed in gnome-software (Ubuntu Yakkety):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Jeremy, or anyone else affected,

Accepted gnome-software into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.20.1+git20160923.2.7374bdc-0ubuntu1~xenial1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in gnome-software (Ubuntu Xenial):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Confirmed warning is now gone in xenial.

description: updated
tags: added: verification-done
removed: verification-needed
Revision history for this message
Martin Pitt (pitti) wrote : Update Released

The verification of the Stable Release Update for gnome-software has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.20.1+git20160923.2.7374bdc-0ubuntu1~xenial1

---------------
gnome-software (3.20.1+git20160923.2.7374bdc-0ubuntu1~xenial1) xenial; urgency=medium

  * New upstream snapshot from the wip/ubuntu branch at
    git://git.gnome.org/gnome-software.
    - Fix crash on 32 bit arch live images (LP: #1571729)
  * debian/README.source: Update branch name (wip/ubuntu-xenial -> wip/ubuntu).

gnome-software (3.20.1+git20160923.1.0c571f1-0ubuntu1~xenial1) xenial; urgency=medium

  * New upstream snapshot from the wip/ubuntu branch at
    git://git.gnome.org/gnome-software.
    - Fix failure refining first snap doesn't affect other snaps (LP: #1626803)
    - Support snap launching (LP: #1564076)
    - Don't prompt user to upgrade held packages (LP: #1573061)
    - Use /v2/find API instead of obsolete /v2/snaps API for searching (LP: #1596378)
    - Download changelog information on demand (LP: #1574666)
  * debian/control:
    - Depend on aptdaemon

 -- Iain Lane <email address hidden> Fri, 23 Sep 2016 18:28:31 +0100

Changed in gnome-software (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.