[dashboard] Missing UI tests for some functionality

[Valerii Kovalchuk]

Some features are not covered by UI tests in sanity_check.py. These features are highlighted here: https://etherpad.openstack.org/p/murano-ui-uncovered-features

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/403879

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/407761

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/403879
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=aaac5adf420456fc865d98f560a90ace9894bc0c
Submitter: Jenkins
Branch: master

commit aaac5adf420456fc865d98f560a90ace9894bc0c
Author: Felipe Monteiro <email address hidden>
Date: Mon Nov 28 14:49:12 2016 -0500

    Add UI tests for Delete Environment from Details View.

    In addition, added two helper functions to base.py:
      1) def wait_for_alert_message_to_disappear which waits for the
         alert message to completely disappear. This is needed
         because the alert message pops up directly above the
         Delete Environment button in the detail view, causing
         the click() function to fail.
      2) def wait_element_is_visible which waits for an element
         to become "present on the DOM of a page and visible"
         (from documentation). This is not absolutely needed,
         but is included as a "just-in-case".

    Change-Id: I300f23fc566b40cf3f50a344e98ff94cf17bbf9e
    Partial-Bug: #1596196

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/408268

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/408334

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/409861

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/410950

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/408268
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=a1e327576f623ff92ff78bc110cb005dd4593527
Submitter: Jenkins
Branch: master

commit a1e327576f623ff92ff78bc110cb005dd4593527
Author: Felipe Monteiro <email address hidden>
Date: Wed Dec 7 14:21:35 2016 -0500

    Add UI Test for Abandon Environment from Detail View.

    Also removed the helper function wait_element_is_viewable,
    because it is redundant; it can be substituted for the following
    function instead:
      - check_element_on_page
    The removed was only being used by
    test_delete_environment_from_detail_view, which has been updated
    to use the aforementioned function instead.

    Also added 3 new constants:
     - DetailDropdownBtn: the toggle button that needs to be clicked
       on in the env detail view to toggle dropdown menu
     - DetailDropdownMenu: the menu after clicking the former
     - ModalDialog: - the confirmation modal dialog itself

    Change-Id: I7e326e697413c710781d8aa5daf92aa5fbebfbb2
    Partial-Bug: #1596196

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/409861
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=fb263eb3cfbde2a2574575a84db2de010c2361db
Submitter: Jenkins
Branch: master

commit fb263eb3cfbde2a2574575a84db2de010c2361db
Author: Felipe Monteiro <email address hidden>
Date: Mon Dec 12 11:42:33 2016 -0500

    Add UI Tests for Filtering Apps by Tag/Description.

    Also made the following changes:
      - Renamed test_check_search_option -> test_filter_by_name,
        because now that there are multiple search option tests,
        this test more precisely conveys what it is testing.
      - Added helper function wait_for_page_reload to base.py,
        because after a filter is conducted, a page refresh is
        performed; on slow machines, not waiting for page refresh
        throws error, because content hasn't loaded yet.

    Change-Id: Ifecba6563877de7d28b3d3ab4e2b77774b993c7e
    Partial-Bug: #1596196

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/408334
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=6792ab462e39e0f73282812fa610d7efa052ede2
Submitter: Jenkins
Branch: master

commit 6792ab462e39e0f73282812fa610d7efa052ede2
Author: Felipe Monteiro <email address hidden>
Date: Wed Dec 7 17:27:03 2016 -0500

    Add UI Tests for Latest Deployment Log.

    Added two new scenarios:
      - Check expected output in latest deployment log after
        deploying environment.
      - Check expected output after first deployment and again
        after the second deployment of same environment, where
        the expected outputs differ each deployment.

    Also added 3 new constants:
      - DeploymentHistoryLogTab: the Latest Deployment Tab in the
        environment details view.
      - EnvComponentsTab: the Consoles Tab in the environment details
        view. (Used for compatibility with add_to_env.)
      - DeploymentHistoryLogs: the logs themselves, contained in the
        Latest Deployment Tab, which contains the log statements
        for verification.

    Change-Id: Iafee56df7f607fdfa40c3d2ec6d15e696b4ae7b1
    Partial-Bug: #1596196

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/410434
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=24ee71f94e7a3215f86c3f9a7bc672cab6047ebf
Submitter: Jenkins
Branch: master

commit 24ee71f94e7a3215f86c3f9a7bc672cab6047ebf
Author: Felipe Monteiro <email address hidden>
Date: Fri Dec 16 17:07:37 2016 -0500

    Add UI Tests for Deleting Multiple Images.

    Added new scenario for deleting multiple images.

    The scenario tests that each image is deleted
    separately. Afterward, it tests that all the
    images are deleted together.

    Change-Id: Ib5292e3347101a19f5cc01dbc4999584508186c4
    Partial-Bug: #1596196

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/407761
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=e6e9267fea0b9561342ddb8979614df84081572c
Submitter: Jenkins
Branch: master

commit e6e9267fea0b9561342ddb8979614df84081572c
Author: Felipe Monteiro <email address hidden>
Date: Tue Jan 10 11:30:20 2017 -0500

    Add UI tests for Deploy/Abandon Environment from Table View.

    Scenarios for the following UI tests were added to sanity_check:
      - Deploy from table view
      - Abandon from table view

    Also added helper function in base.py called
    execute_action_from_table_view, which does the following:
      - Clicks the drop-down button in the table view corresponding
        to a specific environment.
      - Waits for the drop-down menu to appear.
      - Clicks the designated action button from the menu.

    Change-Id: I61890d1795e92789fca0265e814914a0dc5a91ff
    Partial-Bug: #1596196

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/410950
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=e507341b22f4e626e26ee0f1f5f50d44a3d23348
Submitter: Jenkins
Branch: master

commit e507341b22f4e626e26ee0f1f5f50d44a3d23348
Author: Felipe Monteiro <email address hidden>
Date: Wed Dec 14 15:42:24 2016 -0500

    Add UI Tests for Filtering Packages by Name/Type/Keyword.

    Also made the following changes:
      - Added 4 new consts related to package filtering.
      - Added sec keyword to check_element_on_page to override default
        wait time.
      - Refactored package init to use new method upload_package,
        to make dynamically creating packages possible.

    Change-Id: Ia37a6789ef454cb6ec17d8b2a9bd806fdad5791f
    Partial-Bug: #1596196

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/413189
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=ec3d246e5643a59fe2cea917fb00ba63dab0a587
Submitter: Jenkins
Branch: master

commit ec3d246e5643a59fe2cea917fb00ba63dab0a587
Author: Felipe Monteiro <email address hidden>
Date: Fri Jan 13 11:27:50 2017 -0500

    Add UI Tests for Various Package Scenarios.

    The following 4 scenarios were added to TestSuitePackage:
      1) Delete package.
      2) Delete multiple packages.
      3) Toggle multiple packages enabled.
      4) Toggle multiple packages public.

    Also added addCleanup to delete dynamically created packages
    rather than doing a manual deletion of the packages in
    recently added package tests. This is better because if
    any of those tests fail, the deletion will not happen,
    causing other tests to potentially fail, making it much harder
    to debug.

    Change-Id: I2c5f9240f67cbb672eaff08d5118c8d260fbf56e
    Partial-Bug: #1596196

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/416728
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=840bcd21d0e8c1e23f9cf9dc358208b330feda15
Submitter: Jenkins
Branch: master

commit 840bcd21d0e8c1e23f9cf9dc358208b330feda15
Author: Felipe Monteiro <email address hidden>
Date: Fri Jan 13 11:42:04 2017 -0500

    Add UI Test for Correct # Apps by Category in Catalog View.

    Added UI test for the scenario:
    "Show correct number of apps in a category in catalog view".

    Also made the following 2 tests atomic:
      1) test_add_pkg_to_category_non_admin
      2) test_add_pkg_to_category_without_count
    They were not cleaning up after themselves; they were changing
    class-level package categories, which was causing the new
    test to fail, when run in conjunction with the 2 tests above.

    Change-Id: Iac9ba8ed168f4a8cf9144aca285159f66ccea165
    Partial-Bug: #1596196

[Felipe Monteiro (fm577c)]

Kirill, I believe most of the additional UI tests in the etherpad have been implemented. I'll go over the etherpad document to confirm whether they have all been implemented to double-check.