Make print py3 compatible

Bug #1595773 reported by Ji.Wei
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel Plugins
In Progress
Undecided
Unassigned
OpenStack Compute (nova)
Fix Released
Undecided
jingtao liang
OpenStack Object Storage (swift)
Fix Released
Undecided
YaoZheng_ZTE
daisycloud-core
New
Undecided
Unassigned

Bug Description

In PY3,

Remove the print "", join the print () function to achieve the same function.

Python 3:

#!/usr/bin/python
# -*- coding: utf-8 -*-
print ("cinder")

print "cinder"

  File "code", line 5
    print "cinder"
                 ^
SyntaxError: Missing parentheses in call to 'print'

Ji.Wei (jiwei)
Changed in cinder:
assignee: nobody → Ji.Wei (jiwei)
Changed in nova:
assignee: nobody → Ji.Wei (jiwei)
Changed in python-cinderclient:
assignee: nobody → Ji.Wei (jiwei)
Changed in glance:
assignee: nobody → YaoZheng_ZTE (zheng-yao1)
Changed in glance-store:
assignee: nobody → YaoZheng_ZTE (zheng-yao1)
Changed in tempest:
status: New → Invalid
Changed in glance:
status: New → Invalid
Ji.Wei (jiwei)
no longer affects: neutron
no longer affects: tempest
Changed in rally:
assignee: nobody → Ji.Wei (jiwei)
Changed in nova:
assignee: Ji.Wei (jiwei) → nobody
Changed in nova:
assignee: nobody → jingtao liang (liang-jingtao)
Changed in nova:
status: New → In Progress
Changed in swift-swf:
assignee: nobody → jingtao liang (liang-jingtao)
Changed in swift-swf:
assignee: jingtao liang (liang-jingtao) → nobody
Ji.Wei (jiwei)
no longer affects: glance
Changed in swift-swf:
assignee: nobody → YaoZheng_ZTE (zheng-yao1)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/333669

Revision history for this message
Steve Martinelli (stevemar) wrote :

a quick scan of the keystone code base shows this is not an issue, we only use print in the py3 friendly way. marking this as invalid, re-open if i'm wrong.

Changed in keystone:
status: New → Invalid
Ji.Wei (jiwei)
no longer affects: keystone
Ji.Wei (jiwei)
Changed in fuel-plugins:
assignee: nobody → Ji.Wei (jiwei)
no longer affects: cinder
affects: swift-swf → swift
Changed in swift:
status: New → In Progress
Ji.Wei (jiwei)
no longer affects: rally
no longer affects: python-cinderclient
Ji.Wei (jiwei)
Changed in fuel-plugins:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/333669
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a0f5a56a150f82ddd90178f487cb9a398bed8ea3
Submitter: Jenkins
Branch: master

commit a0f5a56a150f82ddd90178f487cb9a398bed8ea3
Author: liangjingtao <email address hidden>
Date: Fri Jun 24 11:23:16 2016 +0800

    Make print py3 compatible

    In PY3,remove the print "", join the print () function to achieve
    the same function,this patch is to fix it.

    Change-Id: Ie860e912b0c7101fd9d1d5c8373db8688f99122c
    Closes-Bug: #1595773

Changed in nova:
status: In Progress → Fix Released
Ji.Wei (jiwei)
Changed in daisycloud-core:
assignee: nobody → Ji.Wei (jiwei)
no longer affects: glance-store
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.openstack.org/333801
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=4a9f7378ec4d73c8bf16748e24bec45aa503b08e
Submitter: Jenkins
Branch: master

commit 4a9f7378ec4d73c8bf16748e24bec45aa503b08e
Author: zhengyao1 <email address hidden>
Date: Fri Jun 24 17:34:26 2016 +0800

    make print python3 compatible

    The print '' in python2 was supported. But in python3,
    print '' was error. In python3, recommend using print()
    instead. This patch will fix it.

    Change-Id: I226461b0400023dc44238d9e5ee1ae2f2430de9e
    Closes-Bug: #1595773

Changed in swift:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/nova 14.0.0.0b2

This issue was fixed in the openstack/nova 14.0.0.0b2 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/swift 2.9.0

This issue was fixed in the openstack/swift 2.9.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (feature/hummingbird)

Fix proposed to branch: feature/hummingbird
Review: https://review.openstack.org/363111

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (feature/hummingbird)
Download full text (84.1 KiB)

Reviewed: https://review.openstack.org/363111
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=1ab2a296f58ae76aeffef9f3f0fb90e15358be27
Submitter: Jenkins
Branch: feature/hummingbird

commit 3b5850836c59c46f2507a7f62aceccf4c37e5d41
Author: gecong1973 <email address hidden>
Date: Tue Aug 30 15:08:49 2016 +0800

    Remove white space between print and ()

    There is a white space between print and ()
    in /tempauth.py, This patch fix it

    Change-Id: Id3493bdef12223aa3a2bffc200db8710f5949101

commit f88e7fc0da2ed6a63e0ea3c3459d80772b3068cd
Author: zheng yin <email address hidden>
Date: Mon Aug 29 20:21:44 2016 +0800

    Clarify test case in common/ring/test_builder

    They use a bare assertRaises(ValueError, ring.RingBuilder, *,*,*), but
    it's not clear which one raises which ValueError(), so I extend them to
    validate the error strings as well.

    Change-Id: I63280a9fc47ff678fe143e635046a0b402fd4506

commit d68b1bd6ddf44c5088e9d02dcb2f1b802c71411b
Author: zhufl <email address hidden>
Date: Mon Aug 29 14:31:27 2016 +0800

    Remove unnecessary tearDown

    This is to remove unnecessary tearDown to keep code clean.

    Change-Id: Ie70e40d6b55f379b0cc9bc372a35705462cade8b

commit d2fc2614575b04fd9cab5ae589880b92eee9b186
Author: Matthew Oliver <email address hidden>
Date: Fri Aug 19 16:17:31 2016 +1000

    Authorise versioned write PUTs before copy

    Currently a versioned write PUT uses a pre-authed request to move
    it into the versioned container before checking whether the
    user is authorised. This can lead to some interesting behaviour
    whereby a user can select a versioned object path that it does not
    have access to, request a put on that versioned object, and this
    request will execute the copy part of the request before it fails
    due to lack of permissions.

    This patch changes the behaviour to be the same as versioned DELETE
    where the request is authorised before anything is moved.

    Change-Id: Ia8b92251718d10b1eb44a456f28d3d2569a30003
    Closes-Bug: #1562175

commit c1ef6539b6ba9d2e4354c9cd2eec8a0195cdb19f
Author: Clay Gerrard <email address hidden>
Date: Thu Aug 25 11:00:49 2016 -0700

    add test for expirer processes == process

    This is a follow up from a change that improved the error message.

    Related-Change: I3d12b79470d122b2114f9ee486b15d381f290f95

    Change-Id: I093801f3516a60b298c13e2aa026c11c68a63792

commit 01477c78c1163822de41484e914a0736e622085b
Author: zheng yin <email address hidden>
Date: Thu Aug 25 15:37:42 2016 +0800

    Fix ValueError information in obj/expirer

    I fix error information in raise ValueError(...)
    For example:
        if a>=b:
            # It should be under below and not 'a must be less than or equal to b'
            raise ValueError('a must be less than b')

    Change-Id: I3d12b79470d122b2114f9ee486b15d381f290f95

commit b81f53b964fdb8f3b50dd369ce2e194ee4dbb0b7
Author: zheng yin <email address hidden>
Date: Tue Aug 23 14:26:47 2016 +0800

    Improve readability in the obj server's unit tests

    This change improves the reada...

tags: added: in-feature-hummingbird
Ji.Wei (jiwei)
Changed in daisycloud-core:
assignee: Ji.Wei (jiwei) → nobody
Changed in fuel-plugins:
assignee: Ji.Wei (jiwei) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.