Juniper Openstack

SM Provision: File Line resource should take match with single quotes

Bug #1595747 reported by Nitish Krishna Kaveri
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.0
Fix Committed
High
Nitish Krishna Kaveri
Juniper Openstack r3.0.3.0
Trunk
Fix Committed
High
Nitish Krishna Kaveri
Juniper Openstack r3.1.0.0-fcs

Bug Description

Double quotes used in match one will not match correctly when escape characters are present in the regex
This needs to be changed to single quotes
Example: JMM OPTS in cassandra-env.sh

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/21425
Submitter: Nitish Krishna Kaveri (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/21426
Submitter: Nitish Krishna Kaveri (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/21426
Committed: http://github.org/Juniper/contrail-puppet/commit/78a4eb44d128f9e95b9b5b73c34842a8741194c9
Submitter: Zuul
Branch: R3.0

commit 78a4eb44d128f9e95b9b5b73c34842a8741194c9
Author: nitishkrishna <email address hidden>
Date: Fri Jun 24 12:07:08 2016 -0700

Closes-Bug: #1595747 - Incorrect File_line match causing issues in cassandra config

The JVM OPTS was being set on a new line.
Same issue with a LOG4J kafka parameters.
All matches have been corrected to use single quotes instead of double quotes.

Fixed Conflicts for 3.0

Change-Id: I2c4ab42941a162fed61615c81de40fd9cd96146b

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/21425
Committed: http://github.org/Juniper/contrail-puppet/commit/5f66cc239ae483e37902e7345dc57551a3f23889
Submitter: Zuul
Branch: master

commit 5f66cc239ae483e37902e7345dc57551a3f23889
Author: nitishkrishna <email address hidden>
Date: Fri Jun 24 12:07:08 2016 -0700

Closes-Bug: #1595747 - Incorrect File_line match causing issues in cassandra config

The JVM OPTS was being set on a new line.
Same issue with a LOG4J kafka parameters.
All matches have been corrected to use single quotes instead of double quotes.

Change-Id: I2c4ab42941a162fed61615c81de40fd9cd96146b

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.