snapd uses "never" in systemd unit files when it should be using "no"

[Kyle Fazzari]

Here's a .service file from my system for a service with `restart-condition: never` in the YAML (note the Restart=never):

[Unit]
# Auto-generated, DO NO EDIT
Description=Service for snap application data-writer.service
After=snapd.frameworks.target
Requires=snapd.frameworks.target
X-Snappy=yes

[Service]
ExecStart=/usr/bin/ubuntu-core-launcher snap.data-writer.service snap.data-writer.service /snap/data-writer/x4/bin/write-data from-service
Restart=never
WorkingDirectory=/var/snap/data-writer/x4
Environment="SNAP=/snap/data-writer/x4" "SNAP_DATA=/var/snap/data-writer/x4" "SNAP_NAME=data-writer" "SNAP_VERSION=1.0" "SNAP_REVISION=x4" "SNAP_ARCH=amd64" "SNAP_LIBRARY_PATH=/var/lib/snapd/lib/gl:" "SNAP_USER_DATA=/root/snap/data-writer/x4"

TimeoutStopSec=30
Type=simple

[Install]
WantedBy=multi-user.target

[Yann Sionneau (yann-sionneau)]

I am also affected by this bug.
I can confirm.

[Yann Sionneau (yann-sionneau)]

On the same kind of topic, daemon: oneshot is buggy and cannot work also.
Because it does set Restart=on-failure, which is refused by systemd.

And because of this very bug (the one reported by Kyle), you cannot use restart-condition: never to make oneshot daemon work.

[Kyle Fazzari (kyrofa)]

Adding snapcraft to this bug as well-- it needs to accept "no."

[Kyle Fazzari (kyrofa)]

Snapcraft could also accept "never" if snapd means to rewrite that to "no."

[Kyle Fazzari (kyrofa)]

snapd fix: https://github.com/snapcore/snapd/pull/1551

[Kyle Fazzari (kyrofa)]

snapcraft fix: https://github.com/snapcore/snapcraft/pull/659

[Yann Sionneau (yann-sionneau)]

Thanks for the quick fix!