Plugging a VIFOpenVSwitch vif creates extraneous linux bridge and veth pair

[Rawlin Peters]

A vif of type VIFOpenVSwitch only needs to be attached directly to the OVS bridge. However, due to VIFOpenVSwitch inheriting from VIFBridge, the ovs plugin incorrectly tries to plug the VIFOpenVSwitch vif like a VIFBridge. Because of this, the ovs plugin creates an extraneous linux bridge and connects it to the target OVS bridge using a veth pair. We end up with the following example: http://paste.openstack.org/show/521700/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/333486
Committed: https://git.openstack.org/cgit/openstack/os-vif/commit/?id=d5b119ba37d5c724d1279cb2292dce05c32b51a0
Submitter: Jenkins
Branch: master

commit d5b119ba37d5c724d1279cb2292dce05c32b51a0
Author: Rawlin Peters <email address hidden>
Date: Thu Jun 23 10:34:25 2016 -0600

    Don't create extraneous linux bridge/veth pair for VIFOpenVSwitch

    VIFOpenVSwitch vifs will be booted by libvirt directly on the target
    bridge. Don't create an extraneous linux bridge with a veth pair
    connection to the target bridge.

    VIFOpenVSwitch inherits from VIFBridge, so the following check causes
    _plug_bridge() to be incorrectly executed for vifs of type
    VIFOpenVSwitch:

        if isinstance(vif, objects.vif.VIFBridge):
            self._plug_bridge(vif, instance_info)

    Fix this to check for instances of VIFOpenVSwitch first and do nothing
    in that case.

    Closes-Bug: #1595614
    Change-Id: I447395cc50aa8fc21fa714b76f4cb1f5e79846ae

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/os-vif 1.1.0 release.