API file uses namespace inconsistently
Bug #1595461 reported by
Zsombor Egri
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu SDK API |
Fix Committed
|
High
|
Cris Dywan | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Cris Dywan |
Bug Description
With the recent move of c++ types from Ubuntu.Components plugin into UbuntuToolkit and embedding them into a namespace caused API dump to use the namespace inconsistently. In some places has a "." in other places a "::".
Related branches
lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/listsAndNameSpaces
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Tim Peeters: Approve
-
Diff: 1297 lines (+337/-327)3 files modifiedapicheck/apicheck.cpp (+30/-19)
components.api (+301/-302)
tests/api/components.api (+6/-6)
lp:~ubuntu-sdk-team/ubuntu-sdk-api/listsAndNameSpaces
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Benjamin Zeller: Approve
-
Diff: 117 lines (+35/-25)2 files modifiedapicheck/apicheck.cpp (+29/-19)
tests/qml/Extinct.Animals.api (+6/-6)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Christian Dywan (kalikiana) |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → Fix Committed |
Changed in ubuntu-sdk-api: | |
assignee: | nobody → Christian Dywan (kalikiana) |
status: | New → In Progress |
importance: | Undecided → High |
To post a comment you must log in.
This bug was fixed in the package ubuntu-ui-toolkit - 1.3.2060+ 16.10.20160814
--------------- 16.10.20160814) yakkety; urgency=medium
ubuntu-ui-toolkit (1.3.2060+
[ Zoltan Balogh ] estCase tests.
* Fix OptionSelectorT
* Fix more OptionSelector autopilot tests
[ Timo Jyrinki ]
* Disable documentation building for GLES builds. Fixes LP: #1606222.
* Replace abs with qFabs due to GCC6 breakage. Fixes LP: #1610943.
* Limit s390x dependencies more due to upstart/s390x problems and removed
packages in archives. Fixes LP: #1610951
[ Andrea Bernabei ]
* ListItemLayout doc: add elide mode change example and add section about
labels default properties values. Fixes LP: #1603450.
* ListItemLayout doc: add explicit note about the need to bind ListItem's
height to layout's height.
* More Scrollbar optimizations: 20% faster creation time. Fixes LP: #1606451
* Scrollbar: fix wrong thumb color on tap/mouse release and increase coverage
of hover states unit tests. Fixes LP: #1608897
[ Zsombor Egri ]
* Fix null pointer property initializer used with 1.3 PageWrapper.
Fixes LP: #1604780.
* Fix BottomEdge content URL preloading. Fixes LP: #1604509.
[Albert Astals Cid ] :resolveResourc e: Prefer image path if it exists. This saves :resolveResourc e call down
* UCUnits:
searching the disk for @gu images, which is a big speedup. According to
callgrind loading 100 images from a folder that contains 380 images goes
from around 3 million instructions per UCUnits:
to around 10 thousand. This optimization is ok since it is not correct to
ship both image.png and image@20.png. You either have to ship gu-enabled
files or not, but mixing them is not allowed. Searched for cases in which
that may be happening in my phone and found none. Fixes LP: #1604029.
[ Tim Peeters ] Popover Autopilot CPO tests.
* Configure colors of the buttons in the ActionBar and PageHeader through
their Styles. Fixes LP: #1597774.
* Fix assigning of constant values to a grouped property in StyleHints.
Fixes LP: #1602836.
* Fix list view keyboard navigation for RightToLeft and BottomToTop
directions. Fixes LP: #1605634
* Use external QML files instead of embedded QML strings for autopilot tests.
Fixes LP: #1578319
* Fix failing autopilot header tests.
* Fix ActionSelection
[Christian Dywan ]
* Include indexes in "offline" docs and filter out link errors.
Fixes LP: #1603937.
* Increase focus ring thickness from 1dp to 2dp. Fixes LP: #1602690.
* Add a snippet about tests to the toplevel README
* Enter/Return to trigger, Space to expand ComboButton. Fixes LP: #1523817.
* Initialize engine variable before using it in the _engine case.
* Use Qt.rgba instead of #0000 checking ListItem default color.
Fixes LP: #1560004
* Don't use a different .desktop file in the gallery tests.
Fixes LP: #1578319
* Update scaling docs, set QT_SCALE_FACTOR and unset GRID_UNIT_PX.
Fixes LP: #1610208
[ Florian Boucault ]
* Sections: load Icons asynchronously.
-- Zoltán Balogh <email address hidden> Sun, 14 Aug 2016 09:06:46 +0000