ml2 Use None for portbinding.host instead of an empty String

Bug #1595250 reported by Andreas Scheuring
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Invalid
Low
Unassigned

Bug Description

Seems like ML2 portbinding uses '' for indicating that the port is bound to no host, while in times before ml2 "None" was used. This leads to some strange checks in the code like [1]

This bug is to clean this up internally. The API still should take both values, an empty string and none, but some code at the api layer should normalize that to None. In addition the values in the ml2_portbinding (and dvr portbinding) table need to be migrated.

Another related patch that introduced None values for ml2 portbiding as well was : https://review.openstack.org/#/c/181867/

[1] https://review.openstack.org/#/c/320657/1/neutron/db/ipam_backend_mixin.py

Changed in neutron:
status: New → Confirmed
importance: Undecided → Low
Changed in neutron:
assignee: nobody → Anindita Das (anindita-das)
Revision history for this message
Anindita Das (anindita-das) wrote :

Hi John,

I have assigned this bug to myself. I am not able to reproduce it. Can you please tell me how I can reproduce this bug?

Thanks,
Anindita

Changed in neutron:
assignee: Anindita Das (anindita-das) → nobody
Changed in neutron:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.