fact by network are failing when facter.value is nil

[Sofer Athlan-Guyot]

When using tripleo we've got those error message:

    Could not retrieve fact='fqdn_external', resolution='<anonymous>': undefined method `empty?' for nil:NilClass
    Could not retrieve fact='fqdn_external', resolution='<anonymous>': undefined method `empty?' for nil:NilClass
    Could not retrieve fact='fqdn_internalapi', resolution='<anonymous>': undefined method `empty?' for nil:NilClass

See the full log there
http://logs.openstack.org/83/332483/2/check-tripleo/gate-tripleo-ci-centos-7-ha/5e98113/logs/undercloud/var/log/undercloud_install.txt.gz#_2016-06-22_05_45_52_000

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/332736
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=edde5b9a28449f270d7813edca6f49aead4fb5a9
Submitter: Jenkins
Branch: master

commit edde5b9a28449f270d7813edca6f49aead4fb5a9
Author: Sofer Athlan-Guyot <email address hidden>
Date: Wed Jun 22 12:23:10 2016 +0200

    Fix retrieval of hostname fact based on network.

    When Facter.value(:domain) is nil the facts fqdn_<network> are failing
    with :

    Could not retrieve fact='fqdn_external', resolution='<anonymous>': undefined method `empty?' for nil:NilClass

    Change-Id: I3e7fa983d4cf91c6ab25f9aa4c353b364f44826e
    Closes-bug: 1595125

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 5.0.0.0b3 development milestone.