Juniper Openstack

SM Mon: Setup_keys should not be called for modify servers

Bug #1594917 reported by Nitish Krishna Kaveri
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Committed
High
Nitish Krishna Kaveri
Juniper Openstack r3.1.0.0-fcs

Bug Description

Function setup_keys in Server Manager Mon Base Plugin is being called wrongly even when servers are just being modified. The if condition is setup keys looks for ip_address in the server hash and this is not found in modify server json

Also when adding new servers, the setup_keys has become a blocking call

See original description
Nitish Krishna Kaveri (nitishk)
description: updated
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/21326
Submitter: Nitish Krishna Kaveri (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/21326
Committed: http://github.org/Juniper/contrail-server-manager/commit/4a3469e04132725198ae2afb406d9c0da5c3daa3
Submitter: Zuul
Branch: master

commit 4a3469e04132725198ae2afb406d9c0da5c3daa3
Author: nitishkrishna <email address hidden>
Date: Tue Jun 21 12:08:35 2016 -0700

Closes-Bug: #1594917 - SSH Key setup should be done only in add keys

Currently it is being done for modify keys as well as happening in the foreground
This check-in moves it to gevent to prevent it from being a blocking call

Change-Id: Ib08a6694154263faf1a68c78868a16d16edbd510

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.