fail to load package ui with glare enabled

[SFilatov]

GET on http://<vip>:8082/v1/catalog/packages/<package id>/ui fails with:
"PackageFormatError: Incorrect package format: Uploaded file /tmp/tmpgCb7ll is not a zip archive\n"

This happens occasionally depending on a package
/usr/lib/python2.7/dist-packages/murano/api/v1/catalog.py:

def get_ui(self, req, package_id):
        ...
        else:
            g_client = self._get_glare_client(req)
            blob_data = g_client.artifacts.download_blob(package_id, 'archive')
            with tempfile.NamedTemporaryFile() as tempf:
                for chunk in blob_data:
                    tempf.write(chunk)
                with load_utils.load_from_file(tempf.name, target_dir=None,
                                               drop_dir=True) as pkg:
                    return pkg.ui

Since load_utils.load_from_file is called inside temp's with construction and it's opened, subsequent zipfile check might fail

[SFilatov (sergeyfilatov)]

I suggest we use streams instead of tempfiles. If we stick to the tempfile way we can either flush or mark it as delete=false, removing with os. Which way we better go?

[Valerii Kovalchuk (vakovalchuk)]

Looks like this issue is already fixed by https://review.openstack.org/#/c/320540/