Better quota management and enforccement

Bug #1594215 reported by Sumit Naiksatam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Group Based Policy
Fix Released
Medium
Sumit Naiksatam

Bug Description

Neutron has implemented an improved Quota enforcement model [1] involving registration and tracking of resource instances. This can be leveraged for GBP resources as well.

[1] https://github.com/openstack/neutron/blob/master/doc/source/devref/quota.rst

Changed in group-based-policy:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to group-based-policy (master)

Reviewed: https://review.openstack.org/331462
Committed: https://git.openstack.org/cgit/openstack/group-based-policy/commit/?id=9519193d9c5dc610aa693efdf072fe6b55903eec
Submitter: Jenkins
Branch: master

commit 9519193d9c5dc610aa693efdf072fe6b55903eec
Author: Sumit Naiksatam <email address hidden>
Date: Sun Jun 19 01:43:56 2016 -0700

    Better quota enforcement for GBP resources

    This patch aligns the quota enforcement in GBP with the
    changes made in Neutron quota management as a part of the
    following blueprint and implementation patches referenced
    therein:
    https://blueprints.launchpad.net/neutron/+spec/better-quotas

    The decorator @resource_registry.tracked_resources in the
    neutron.quota.resource_registry module is applied to the GBP
    and Service Chain plugin __init__ methods.

    In addition, the local_api module is also enhanced to enforce
    quotas when GBP and Service Chain resources are created implicitly.

    Older UTs that test the quotas have been preserved thus validating
    the approach (they have only been moved to the appropriate test classes
    on account of the resource tracking logic having moved from the earlier
    DB modules to the plugin modules).

    Closes-bug: 1594215

    Change-Id: I38093426c89d1f4398c40da1f3392c0988831ff8

Changed in group-based-policy:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to group-based-policy (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/332430

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to group-based-policy (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/332442

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to group-based-policy (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/332450

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to group-based-policy (stable/mitaka)

Reviewed: https://review.openstack.org/332430
Committed: https://git.openstack.org/cgit/openstack/group-based-policy/commit/?id=2bfbf0a651fcf9de212aeff14fa632ac9f38a505
Submitter: Jenkins
Branch: stable/mitaka

commit 2bfbf0a651fcf9de212aeff14fa632ac9f38a505
Author: Sumit Naiksatam <email address hidden>
Date: Sun Jun 19 01:43:56 2016 -0700

    Better quota enforcement for GBP resources

    This patch aligns the quota enforcement in GBP with the
    changes made in Neutron quota management as a part of the
    following blueprint and implementation patches referenced
    therein:
    https://blueprints.launchpad.net/neutron/+spec/better-quotas

    The decorator @resource_registry.tracked_resources in the
    neutron.quota.resource_registry module is applied to the GBP
    and Service Chain plugin __init__ methods.

    In addition, the local_api module is also enhanced to enforce
    quotas when GBP and Service Chain resources are created implicitly.

    Older UTs that test the quotas have been preserved thus validating
    the approach (they have only been moved to the appropriate test classes
    on account of the resource tracking logic having moved from the earlier
    DB modules to the plugin modules).

    Closes-bug: 1594215

    Change-Id: I38093426c89d1f4398c40da1f3392c0988831ff8
    (cherry picked from commit 9519193d9c5dc610aa693efdf072fe6b55903eec)

tags: added: in-stable-mitaka
tags: added: in-stable-liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to group-based-policy (stable/liberty)

Reviewed: https://review.openstack.org/332442
Committed: https://git.openstack.org/cgit/openstack/group-based-policy/commit/?id=0521733f594dd54a8a33528795d19858b1d28d44
Submitter: Jenkins
Branch: stable/liberty

commit 0521733f594dd54a8a33528795d19858b1d28d44
Author: Sumit Naiksatam <email address hidden>
Date: Sun Jun 19 01:43:56 2016 -0700

    Better quota enforcement for GBP resources

    This patch aligns the quota enforcement in GBP with the
    changes made in Neutron quota management as a part of the
    following blueprint and implementation patches referenced
    therein:
    https://blueprints.launchpad.net/neutron/+spec/better-quotas

    The decorator @resource_registry.tracked_resources in the
    neutron.quota.resource_registry module is applied to the GBP
    and Service Chain plugin __init__ methods.

    In addition, the local_api module is also enhanced to enforce
    quotas when GBP and Service Chain resources are created implicitly.

    Older UTs that test the quotas have been preserved thus validating
    the approach (they have only been moved to the appropriate test classes
    on account of the resource tracking logic having moved from the earlier
    DB modules to the plugin modules).

    Closes-bug: 1594215

    Change-Id: I38093426c89d1f4398c40da1f3392c0988831ff8
    (cherry picked from commit 9519193d9c5dc610aa693efdf072fe6b55903eec)
    (cherry picked from commit 2bfbf0a651fcf9de212aeff14fa632ac9f38a505)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on group-based-policy (stable/kilo)

Change abandoned by Sumit Naiksatam (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/332450
Reason: Resource reservation and the better quota management was introduced in Neutron in liberty.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.