id-utils Fails to Parse Indented C Preprocessor Statements.

Bug #1594 reported by Ralph Corderoy
4
Affects Status Importance Assigned to Milestone
id-utils (Debian)
Fix Released
Unknown
id-utils (Ubuntu)
Fix Released
Medium
MOTU Reviewers Team

Bug Description

mkid(1), and therefore xtokid(1), seem to get confused by indented C
preprocessor statements.

    $ cat id-utils-bug.c
    #include "foo.h"
    #ifdef BAR
      #include <bar.h>
    #endif
    foo bar
    $ xtokid id-utils-bug.c
    foo.h
    BAR
    include
    bar
    h
    foo
    bar

The indented line is generating a token for `include', and `bar.h'
should be one token like `foo.h' was before it.

This is id-utils version 3.2d-10.

Revision history for this message
Ralph Corderoy (ralph-inputplus) wrote :

It's fixed in GNU's CVS already, but id-utils is without a maintainer so
I guess that's why, despite the bug fix being in 1999, it hasn't made it
into a new release. Perhaps Debian can include some of the patches?

    http://savannah.gnu.org/cgi-bin/viewcvs/idutils/idutils/libidu/scanners.c.diff?r1=1.7&r2=1.8

Changed in id-utils:
assignee: nobody → motu
Revision history for this message
Daniel Robitaille (robitaille) wrote :

Confirmed in Dapper (beta)

Changed in id-utils:
status: Unconfirmed → Confirmed
Revision history for this message
Vassilis Pandis (pandisv) wrote :

Forwarded to Debian ...

Changed in id-utils:
status: Unknown → Unconfirmed
Revision history for this message
Vassilis Pandis (pandisv) wrote :

Attaching a debdiff that fixes the problem...

id-utils (3.2d-11ubuntu1) unstable; urgency=low
  * Don't fail to parse indendent statements (thanks to Ralph Corderoy
    for tracking down the patch). Closes Malone #1594
  * Fix bashism in debian/rules

Revision history for this message
Vassilis Pandis (pandisv) wrote :

Attaching a debdiff that fixes the problem...

id-utils (3.2d-11ubuntu1) unstable; urgency=low
  * Don't fail to parse indendent statements (thanks to Ralph Corderoy
    for tracking down the patch). Closes Malone #1594
  * Fix bashism in debian/rules

Changed in id-utils:
assignee: motu → motureviewers
Revision history for this message
Barry deFreese (bddebian) wrote :

Uploaded. Thanks Vassilis.

Changed in id-utils:
status: Confirmed → Fix Committed
Changed in id-utils:
status: Fix Committed → Fix Released
Changed in id-utils:
status: Unconfirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.