[LCM][Task idempotency] Task "globals" is not idempotent

[Sergey Novikov]

Steps to reproduce:
 1. deploy env with 1 controller + 1 compute + 1 cinder nodes
 2. Rerun task "globals" against compute or cinder node

 # Run task via fuel CLI client
 >fuel node --node-id <node_id> --tasks globals
 #or the direct run of corresponding puppet manifest on target node
 >puppet apply --noop /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp

Expected results: No resource changes
Actual result: The following resources were changed
    - File[/etc/hiera/globals.yaml]

Description of the environment:
env was built from ISO MOS 9.0 #490
Additional information:
puppet's output: http://paste.openstack.org/show/516886/

Additional info:

- On primary node this task is idempotent
- Parameter "default_gateway" is overrided after applying task "globals"
https://github.com/openstack/fuel-library/blob/80a420929ad6dd711de50d5a52e73a92b8f9b6c7/deployment/puppet/osnailyfacter/templates/globals_yaml.erb#L25

- Value of "default_gateway" is set according to value of actual default gateway on node (ip route | grep default)

[Dmitry Klenov (dklenov)]

Moving to 9.0-updates as there is no cluster outage.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/334532

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/334532
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=75e460ab929a76e9e4a8d42740a529b3a476e952
Submitter: Jenkins
Branch: master

commit 75e460ab929a76e9e4a8d42740a529b3a476e952
Author: Maksim Malchuk <email address hidden>
Date: Mon Jun 27 18:18:39 2016 +0300

    Fix 'globals' task idempotentency

    This change removes useless default_gateway variable from the globals
    and from the hiera because it used only in the netconfig task and we
    have puppet function get_default_gateways() to get the gateways.
    Also, this change contains minor styling fix for netconfig.

    Change-Id: If5bc23ddc8b48320ba85f63354d3ebc4e68bb4f7
    Closes-Bug: #1593775
    Signed-off-by: Maksim Malchuk <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/334995

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/334995
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=e1a873158386f772af98d9d8857e007577d18946
Submitter: Jenkins
Branch: stable/mitaka

commit e1a873158386f772af98d9d8857e007577d18946
Author: Maksim Malchuk <email address hidden>
Date: Mon Jun 27 18:18:39 2016 +0300

    Fix 'globals' task idempotentency

    This change removes useless default_gateway variable from the globals
    and from the hiera because it used only in the netconfig task and we
    have puppet function get_default_gateways() to get the gateways.

    Change-Id: If5bc23ddc8b48320ba85f63354d3ebc4e68bb4f7
    Closes-Bug: #1593775
    Signed-off-by: Maksim Malchuk <email address hidden>
    (cherry picked from commit 75e460ab929a76e9e4a8d42740a529b3a476e952)

[Dmitry Belyaninov (dbelyaninov)]

There are no changes on "/etc/hiera/globals.yaml" after:
fuel node --node-id <node_id> --tasks globals
and
puppet apply --noop /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp