Need to add filters for GET /api/transactions/

Bug #1593751 reported by Julia Aranovich
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Dmitry Guryanov
Mitaka
Fix Released
Medium
Dmitry Guryanov

Bug Description

It is possible now to get transaction collection for a particular cluster from API:

GET /api/transactions/?cluster_id=1

But it is impossible to get 'deployment' transactions only or running transactions. Both the following API calls won't return a filtered collection:

GET /api/transactions/?cluster_id=1&tasks_names=deployment

GET /api/transactions/?cluster_id=1&tasks_names=deployment&statuses=running

At the same time these calls are needed for UI within the blueprint: https://blueprints.launchpad.net/fuel/+spec/ui-deployment-history

Changed in fuel:
milestone: none → 10.0
Revision history for this message
Bug Checker Bot (bug-checker) wrote : Autochecker

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

version

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

tags: added: need-info
Dmitry Klenov (dklenov)
Changed in fuel:
assignee: nobody → Fuel Sustaining (fuel-sustaining-team)
Changed in fuel:
assignee: Fuel Sustaining (fuel-sustaining-team) → Dmitry Guryanov (dguryanov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/332019

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/340976

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/340976
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=c179e5d0b4b8a5b4566120eceb81a1d0ed9577c8
Submitter: Jenkins
Branch: master

commit c179e5d0b4b8a5b4566120eceb81a1d0ed9577c8
Author: Dmitry Guryanov <email address hidden>
Date: Tue Jul 12 17:13:00 2016 +0300

    add a function get_param_as_set for handler

    It's a common task to get list of something from URL,
    so let's add this get_param_as_set function and use
    it where possible.

    Change-Id: I4ae28553117f5ae4de35350270a40e3ac6beaf41
    Partial-Bug: #1593751

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/332019
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=8257a0dbcb680e4eb9c19afe027b3a0fbdb0e7be
Submitter: Jenkins
Branch: master

commit 8257a0dbcb680e4eb9c19afe027b3a0fbdb0e7be
Author: Dmitry Guryanov <email address hidden>
Date: Mon Jun 20 19:42:02 2016 +0300

    Add filters for GET /api/transactions/

    Add ability to filter transactions by transaction type
    and status.

    Examples:
     GET /api/transactions/?statuses=error
     GET /api/transactions/?cluster_id=2&transaction_types=provision,reset_environments

    Closes-Bug: #1593751

    Change-Id: If4443045992bfc3816ae219e7607f6897767ba5b

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/354171

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/354657

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/354657
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=ecef951437fa694d59fff418c68d45e78dc30aa8
Submitter: Jenkins
Branch: stable/mitaka

commit ecef951437fa694d59fff418c68d45e78dc30aa8
Author: Dmitry Guryanov <email address hidden>
Date: Fri Aug 12 13:13:57 2016 +0300

    add a function get_param_as_set for handler

    It's a common task to get list of something from URL,
    so let's add this get_param_as_set function and use
    it where possible.

    Backport of commit c179e5d0b4b8a5b4566120eceb81a1d0ed9577c8
    from master.

    Change-Id: I9bf4a24d908eca9593beb39453e2b088e81e5a66
    Partial-Bug: #1593751

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/354171
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=7a829a1d7873bf79c9e5736a6faaec11fba98192
Submitter: Jenkins
Branch: stable/mitaka

commit 7a829a1d7873bf79c9e5736a6faaec11fba98192
Author: Dmitry Guryanov <email address hidden>
Date: Mon Jun 20 19:42:02 2016 +0300

    Add filters for GET /api/transactions/

    Add ability to filter transactions by transaction type
    and status.

    Examples:
     GET /api/transactions/?statuses=error
     GET /api/transactions/?cluster_id=2&transaction_types=provision,reset_environments

    Closes-Bug: #1593751

    Change-Id: If4443045992bfc3816ae219e7607f6897767ba5b
    (cherry picked from commit 8257a0dbcb680e4eb9c19afe027b3a0fbdb0e7be)

tags: added: on-verification
Revision history for this message
Tatyana Kuterina (tkuterina) wrote :

Verified on 9.1 snapshot #165

tags: removed: on-verification
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 10.0.0rc1

This issue was fixed in the openstack/fuel-web 10.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 10.0.0

This issue was fixed in the openstack/fuel-web 10.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.