unit tests are not using testtools

Bug #1593079 reported by Leo Arias
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Snapcraft
Fix Released
Low
Leo Arias

Bug Description

testtools is used in the integration and snaps test suites. It would be nice to use it in the unittests too.

[Impact]

 * For users, None.

 * Testtools adds extra features that we will be able to use in unittests.

[Test Case]

 * N/A

[Regression Potential]

 * This could make unit tests fail. They are executed before merging the branch into master, so we are covered.

Leo Arias (elopio)
Changed in snapcraft:
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Leo Arias (elopio)
milestone: none → 2.12
Revision history for this message
Leo Arias (elopio) wrote :

We have a conflict with the scenarios.
Some of our tests use subTest, which is only supported in unittest, not in testtools.

I reported this: https://github.com/testing-cabal/testtools/issues/235

I wanted to get rid of testscenarios and use subTests everywhere. But I also wanted to use testtools everywhere. Both are not possible at the moment.

Changed in snapcraft:
status: In Progress → Confirmed
milestone: 2.12 → none
Leo Arias (elopio)
Changed in snapcraft:
status: Confirmed → In Progress
Revision history for this message
Sergio Schvezov (sergiusens) wrote :
Changed in snapcraft:
status: In Progress → Fix Committed
milestone: none → 2.23
Revision history for this message
Leo Arias (elopio) wrote :

This is not done yet, it's missing another massive change of all the 300 assertRaises.

Changed in snapcraft:
status: Fix Committed → In Progress
Changed in snapcraft:
milestone: 2.23 → 2.24
Revision history for this message
Leo Arias (elopio) wrote :

This is the one that closed the bug:
https://github.com/snapcore/snapcraft/pull/948

Changed in snapcraft:
status: In Progress → Fix Committed
Kyle Fazzari (kyrofa)
Changed in snapcraft:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.