[upgrade] octane does not properly log names of backup archivators

Bug #1592969 reported by Ilya Kharin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Wishlist
Ilya Kharin
Mitaka
Fix Released
Wishlist
Ilya Kharin

Bug Description

Detailed bug description:
 octane improperly logs messages with names of archivators, e.g.:
  Start backup <property object at 0x27cb5d0>

Steps to reproduce:
 * Install octane on the master node with the 9.0 release
 * Perform the backup procedure using the fuel-repo-backup command

Actual result:
 [root@fuel ~]# octane --debug -v fuel-repo-backup --to repos_and_images.tar.gz [308/1879]
 2016-06-15 13:03:11 INFO octane.commands.backup Start backup <property object at 0x27cb5d0>
 2016-06-15 13:03:11 INFO octane.util.subprocess Started process sudo[26377]: sudo -u postgres psql nailgun --tuples-only --no-align -c 'select editable from attributes;'
 2016-06-15 13:03:12 INFO octane.util.subprocess Process sudo finished with return value 0
 2016-06-15 13:06:05 INFO octane.commands.backup Finish backup <property object at 0x27cb5d0>
 2016-06-15 13:06:05 INFO octane.commands.backup Start backup <property object at 0x27cb5d0>
 2016-06-15 13:06:05 INFO octane.util.subprocess Started process sudo[26428]: sudo -u postgres psql nailgun --tuples-only --no-align -c 'select generated from attributes;'
 2016-06-15 13:06:06 INFO octane.util.subprocess Process sudo finished with return value 0
 2016-06-15 13:06:28 INFO octane.commands.backup Finish backup <property object at 0x27cb5d0>

Expected result:
 [root@fuel ~]# octane --debug -v fuel-repo-backup --to repos_and_images.tar.gz
 2016-06-15 20:19:27 INFO octane.commands.backup Start backup mirrors
 2016-06-15 20:19:27 INFO octane.util.subprocess Started process sudo[7891]: sudo -u postgres psql nailgun --tuples-only --no-align -c 'select editable from attributes;'
 2016-06-15 20:19:27 INFO octane.util.subprocess Process sudo finished with return value 0
 2016-06-15 20:21:53 INFO octane.commands.backup Finish backup mirrors
 2016-06-15 20:21:53 INFO octane.commands.backup Start backup repo
 2016-06-15 20:21:53 INFO octane.util.subprocess Started process sudo[7943]: sudo -u postgres psql nailgun --tuples-only --no-align -c 'select generated from attributes;'
 2016-06-15 20:21:53 INFO octane.util.subprocess Process sudo finished with return value 0
 2016-06-15 20:22:14 INFO octane.commands.backup Finish backup repo

Reproducibility:
 Constantly.

Description of the environment:
 A master node with 8.0 or 9.0.

Ilya Kharin (akscram)
Changed in fuel:
importance: Undecided → Wishlist
status: New → Confirmed
assignee: nobody → Ilya Kharin (akscram)
milestone: none → 8.0-updates
Ilya Kharin (akscram)
tags: added: team-upgrades
Changed in fuel:
status: Confirmed → In Progress
Ilya Kharin (akscram)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (master)

Reviewed: https://review.openstack.org/329952
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=4459e156e00adfee279760d2167109718ffd6ccf
Submitter: Jenkins
Branch: master

commit 4459e156e00adfee279760d2167109718ffd6ccf
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 15 16:18:43 2016 +0300

    Fix logging for backup archivators

    The backup_restore.Base class has the archivator_name property that is
    used to log messages before and after the backup call. This property
    should be used only for instance-bound objects and not classes.

    Closes-Bug: #1592969
    Change-Id: Ib3b4542a5882cba3ac4e0468ccd8d407d8694162

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/343952

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (stable/mitaka)

Reviewed: https://review.openstack.org/343952
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=7779b88f8bb475780cebf905eb52daca6b9af611
Submitter: Jenkins
Branch: stable/mitaka

commit 7779b88f8bb475780cebf905eb52daca6b9af611
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 15 16:18:43 2016 +0300

    Fix logging for backup archivators

    The backup_restore.Base class has the archivator_name property that is
    used to log messages before and after the backup call. This property
    should be used only for instance-bound objects and not classes.

    Closes-Bug: #1592969
    Change-Id: Ib3b4542a5882cba3ac4e0468ccd8d407d8694162
    (cherry picked from commit 4459e156e00adfee279760d2167109718ffd6ccf)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (master)

Fix proposed to branch: master
Review: https://review.openstack.org/351721

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-octane (master)

Change abandoned by Ilya Kharin (<email address hidden>) on branch: master
Review: https://review.openstack.org/351721
Reason: This patch have to go in stable/mitaka instead of master.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/351728

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (stable/mitaka)
Download full text (17.8 KiB)

Reviewed: https://review.openstack.org/351728
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=3101bf302ea0f2d501fd42a6ae6046c3587ac093
Submitter: Jenkins
Branch: stable/mitaka

commit a05d2ecf13e15c12f10e1517fae425e583e0d714
Author: Nikita Zubkov <email address hidden>
Date: Thu Aug 4 17:51:56 2016 +0300

    fix ssh connection auth

    According to spec [1] service user must use key authentication​ for ssh

    [1] https://github.com/openstack/fuel-specs/blame/ba4504/specs/9.0/fuel-nonroot-openstack-nodes.rst#L61-L64

    Change-Id: I461f659d4f0985283a43ec6a702bdd78af91a072

commit 7140398e501879a4e1f5605f3d1cc99195464850
Author: Sergey Abramov <email address hidden>
Date: Tue Aug 2 12:12:57 2016 +0300

    Setup upgrade levels for each fuel version

    Setup upgrade levels block in nova.conf for each fuel version,
    this is required for backward compatibility on RPC.

    Change-Id: I6ccbc34457d11616b015cdb1e46e733b0b49ce58

commit 9e2a419ac79ad591faee9afe16419bf4497eacad
Author: Vladimir Khlyunev <email address hidden>
Date: Mon Aug 1 21:31:56 2016 +0300

    Fix several typos

    Copypasting is evil, lets remove typos

    Change-Id: Icf4bec1a3de954911a469fa98380af2b6175da08

commit 013a7ded2275245a38ee58289dac2bc8b90fa37e
Author: Sergey Abramov <email address hidden>
Date: Wed Jul 20 16:05:10 2016 +0300

    Host evacuation using nova

    Evacuate instance from compute node using
    nova host-evacuate-live except host_evacuation.sh script

    Change-Id: I01a04cfa1ed2aafce7987e523e6b589dea21fbb0

commit 00a1d0dce1f7ae5db6706a59353403516f7913dc
Author: Sergey Abramov <email address hidden>
Date: Tue Jul 19 17:10:44 2016 +0300

    Change shutoff vm command

    * run nova commands using nova util function
    * host filter using get nova node handle method(
        hostname for fuel < 6.1 and fqdn for newer version)

    Change-Id: Ib5c373714e359982b13910a225787167db7b35e9

commit 49357c98313c5f551b13d0877581c5fb5e108db1
Author: Nikita Zubkov <email address hidden>
Date: Mon Jun 27 18:40:13 2016 +0300

    Add `stderr_log_level` parameter to popen

    Now posible to set logging level in popen for logging stderr

    fuel-bootstrap build comand stderr now logged with INFO level

    Change-Id: Ibaa2be54c68ce7a428e07052c917f54e99b95a5e

commit fb582b271dab4bdd10d27149a77c0e1f6a580b9e
Author: Sergey Abramov <email address hidden>
Date: Thu Jul 21 17:56:41 2016 +0300

    Add run_nova_cmd function

    This is required for running nova command on contoller without
    manipulating manipulating with command.

    It makes code easier and more readable

    Usage:

        from fuelclient.objects import environment as environment_obj

        from octane.util import env
        from octane.util import nova

        env_id = ...
        my_env = environment_obj.Environment(env_id)
        controller = env.get_one_controller(my_env)
        nova_cmd_just_run = [...]
        nova_cmd_with_output = [...]
        nova.run_nova_cmd(nova_cmd_just_run, controller, False)
        result = nova.run_nova_cmd(nova_cmd_w...

Revision history for this message
Sergey Novikov (snovikov) wrote :

Verified on snapshot #323

Changed in fuel:
status: Fix Committed → Fix Released
Revision history for this message
Sergey Novikov (snovikov) wrote :

The cherry-pick is not needed into stable/8.0 because the incorrect corresponding log messages are absent in 8.0

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.