hz-dynamic-table has empty div when no facets

Bug #1592835 reported by Matt Borland
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Matt Borland

Bug Description

hz-dynamic-table displays a weird empty div when there are no facets and the user has clicked in the search area.

Tags: angularjs
Matt Borland (palecrow)
tags: added: angularjs
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/329994

Changed in horizon:
assignee: nobody → Matt Borland (palecrow)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/331412

Changed in horizon:
assignee: Matt Borland (palecrow) → Lawrance (jing)
Changed in horizon:
assignee: Lawrance (jing) → Matt Borland (palecrow)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/329994
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=30e37aaf2cd76689c9cfe5a6b9d2127e6e76d837
Submitter: Jenkins
Branch: master

commit 30e37aaf2cd76689c9cfe5a6b9d2127e6e76d837
Author: Matt Borland <email address hidden>
Date: Wed Jun 15 08:55:08 2016 -0600

    Fix hz-dynamic-table formatting for magic-search and actions

    Using https://review.openstack.org/#/c/309561/ as a guide, this patch
    cleans up formatting for actions and the magic-search bar. It:
     * Pads the action buttons a little; they are not part of a button-group.
     * Does not display the dangling empty facet list if there are no facets.
     * Aligns the batch actions to the right when placed inline with search.
     * Gives more room to the search bar

    Change-Id: Iced01bb792ee36699e653bf3c332341bb097e80f
    Closes-Bug: 1592834
    Closes-Bug: 1592835

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Liuqing Jing (<email address hidden>) on branch: master
Review: https://review.openstack.org/331412

Changed in horizon:
importance: Undecided → Low
milestone: none → newton-2
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 10.0.0.0b2

This issue was fixed in the openstack/horizon 10.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.