No production sounds on some maps (8018)

[toptopple]

No production sounds audible on some maps while one others. Conditions yet to be determined; perhaps a fault related to map age and format?

Tested: Build 8018, playing Romans, building = sawmill
Tested maps with sound emerging: Far North
Tested maps without sound emerging: Strands of Malac'Mor, Glacier Lake

Save-games attached.

[kaputtnik (franku)]

I can confirm this with the attached savegames and a new game with map Glacier Lake.

Open Glacier lake in editor and saving at another locations results in the same behavior: No Sound for the sawmill. So i guess its not a fault to map age and format, because all map related things get saved new.

Creating a new map with snow terrains results also in the same: No sound for the sawmill.

[kaputtnik (franku)]

I assume there is something wrong with the function stereo_position() in sound_handler.cc. It calculates the position of a sound and if it is in the viewport. Under some circumstances it returns -1 (not in viewport) although the sound should be played (f.e. the sawmill is in the viewport)

If you play the map "Glacier lake" as second player, the sawmill sound is played if it is on the right half of the screen.

This would also explain my observation commented in https://bugs.launchpad.net/widelands/+bug/1500531/comments/5

Someone else should look into that further :-)

[toptopple (7010622-q-deactivatedaccount)]

What is remarkable here is that the error only affects production sounds, other types of sounds like workers and animals so far are not reported to be affected. Either this implies that only production sounds are under the stereo calculation or some more intricate condition is at work!

[kaputtnik (franku)]

No, that isn't true. F.e. the several sounds of "wood_cutting" are not to hear or the shout from the woodcutter when the tree is just cutted: "timber"

Attached is a savegame for testing. It contains only one tribe so that investigating isn't violated with sounds from an addtional tribe.

[kaputtnik (franku)]

Seems like the viewport is not correct calculated.

The linked branch has some logoutput.

[Klaus Halfmann (klaus-halfmann)]

Be carefull with that savegame only_one_tribe.wgf there is no need to produce planks
unless you increase the value in the ecomonmy...

[Klaus Halfmann (klaus-halfmann)]

Played that only_one_tribe.wgf via ./widelands --xres=800 --xres=600 --fullscreen=false

sounds like the sawing sound _is_ played when the sawmill is in the upper left corner,
but I don here it when it is in the lower right corner. Same applies for woodcutters
"himba". Look like the "Border" is reached when the upper left corner is at (3,2) or such.

[kaputtnik (franku)]

Assuming:
The viewport is the whole screen, so it should have maximum values of the players display resolution. I think this is used here to pay attention if the game is running in window mode. F.e. 800x600 and the window is positioned in the upper right corner of the display. So a sound source from the left side of the window game is played near the middle of stereo. Is this correct? Is this needed?

Nevertheless the values of viewport are sometimes much greater than the screen resolution, and that's the culprit here. But i couldn't find where the viewport is calculated :-S

[kaputtnik (franku)]

I was wrong before :-D

The culprit is (was) that the calculation of positions did not care of the wharparound. Adding a call to MapviewPixelFunctions::normalize_pix should do the trick. But i don't understand why the viewpoint must be substracted from the soundposition ...

The code may could be better, but i am not able to do so. I have added some comments and leaved the log output.

Could someone please test the attached branch if this fixes this? And maybe could take a look at the code to make it better (if this solves the bug) :-)

[toptopple (7010622-q-deactivatedaccount)]

Looks good with several test games. Changed to "Fixed".

[kaputtnik (franku)]

Thanks :-)

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.