Incorrect failure reason for update restriction

[Rabi Mishra]

Update restrict failure reason seems to be incorrect with convergence. As we don't set the resource action to `UPDATE` during the check, it picks up the last resource action.

traceback:

2016-03-08 05:40:29.600 16283 INFO heat.engine.stack [req-039f714a-71e3-4aad-87f5-e44b22feda68 demo demo - default default] Stack UPDATE FAILED (UpdateRestrictedStackTest-318585966): Resource CREATE failed: ResourceActionRestricted: resources.bar: update is restricted for resource.

It should be the below instead :

Resource UPDATE failed: ResourceActionRestricted: resources.bar: update is restricted for resource.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/329762

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/329762
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=992e3b2d09952a09719e1914b06094a96961b9a9
Submitter: Jenkins
Branch: master

commit 992e3b2d09952a09719e1914b06094a96961b9a9
Author: Rabi Mishra <email address hidden>
Date: Wed Jun 15 09:55:21 2016 +0530

    Use the correct action for failure reason

    Use `action` from ResourceFailure exception, if available, as
    there are cases like update restriction check, where we don't
    update the resource action yet.

    Change-Id: I5d43c220669c7a9e8d7dbce6611e062101f8b86b
    Closes-Bug: #1592631

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/heat 7.0.0.0b2 development milestone.