deployment show input_values always empty

[Steven Hardy]

When you create a software deployment resource, the input values aren't visible in the deployment-show API output (you can see them correctly set if you look at the derived config from deployment-list though)

RESP BODY: {"software_deployment": {"status": "COMPLETE", "server_id": "dummy2", "config_id": "8c22bfa7-5d73-479a-b719-132335c9d8bd", "output_values": {"deploy_stdout": null, "deploy_stderr": null, "deploy_status_code": null}, "creation_time": "2016-06-14T22:16:38", "updated_time": "2016-06-14T22:17:43", "input_values": {}, "action": "CREATE", "status_reason": "Outputs received", "id": "18f705e4-e58e-4378-bd10-bb251da1d5c2"}}

{
  "status": "COMPLETE",
  "server_id": "dummy2",
  "config_id": "8c22bfa7-5d73-479a-b719-132335c9d8bd",
  "output_values": {
    "deploy_stdout": null,
    "deploy_stderr": null,
    "deploy_status_code": null
  },
  "creation_time": "2016-06-14T22:16:38",
  "updated_time": "2016-06-14T22:17:43",
  "input_values": {},
  "action": "CREATE",
  "status_reason": "Outputs received",
  "id": "18f705e4-e58e-4378-bd10-bb251da1d5c2"
}

I used this template:

heat_template_version: 2016-10-14

resources:
  config:
    type: OS::Heat::SoftwareConfig
    properties:
      group: script

  deployment:
    type: OS::Heat::SoftwareDeployment
    properties:
      config: {get_resource: config}
      input_values:
        foo: 456
      server: dummy2

Config shows the correct value:

-bash-4.3$ heat deployment-list | grep dummy2
| 18f705e4-e58e-4378-bd10-bb251da1d5c2 | 8c22bfa7-5d73-479a-b719-132335c9d8bd | dummy2 | CREATE | COMPLETE | 2016-06-14T22:16:38 | Outputs received |

heat config-show 8c22bfa7-5d73-479a-b719-132335c9d8bd
  "inputs": [
    {
      "type": "String",
      "name": "foo",
      "value": 456
    },
...

[Steven Hardy (shardy)]

Hmm - I noticed in the example above I forgot to define the input in the SoftwareConfig resource, but adding it doesn't fix it.

So I guess there's a secondary bug, which is that you can pass inputs to SoftwareConfig resources without defining them, because they're evidently automatically created in the derived config.

[Steven Hardy (shardy)]

found the problem, we're only setting the inputs in the derived config, all the input_values in the DB records are empty, patch in-progress

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/329706

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/329706
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=5d999363952a14336ba72f16f85030019d32e55e
Submitter: Jenkins
Branch: master

commit 5d999363952a14336ba72f16f85030019d32e55e
Author: Steven Hardy <email address hidden>
Date: Tue Jun 14 23:59:56 2016 +0100

    Pass input_values when creating SoftwareDeployment resources

    Currently we only store input_values via the derived config, we don't
    pass it at all to the RPC API that creates the deployment, thus it gets
    defaulted to {}. Because the derived config inputs are correctly set,
    this doesn't break the deployment/config operation, but it does lead to
    some misleading empty input_values in the deployment-show CLI output.

    Change-Id: Icad0f66a39de1ce5faec484aa0f34958167c9734
    Closes-Bug: #1592588

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/330919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/330919
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=a3678ae17cadde391a10f702f9cbc4527907c88e
Submitter: Jenkins
Branch: stable/mitaka

commit a3678ae17cadde391a10f702f9cbc4527907c88e
Author: Steven Hardy <email address hidden>
Date: Tue Jun 14 23:59:56 2016 +0100

    Pass input_values when creating SoftwareDeployment resources

    Currently we only store input_values via the derived config, we don't
    pass it at all to the RPC API that creates the deployment, thus it gets
    defaulted to {}. Because the derived config inputs are correctly set,
    this doesn't break the deployment/config operation, but it does lead to
    some misleading empty input_values in the deployment-show CLI output.

    Change-Id: Icad0f66a39de1ce5faec484aa0f34958167c9734
    Closes-Bug: #1592588
    (cherry picked from commit 5d999363952a14336ba72f16f85030019d32e55e)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/heat 7.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 6.1.0 release.