Showing/Hiding apps undoes filters without updating filter UI
Bug #1592407 reported by
Larry Price
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
Medium
|
Unassigned | |||
| Libertine Scope | Status tracked in Trunk | |||||
| Release |
Fix Committed
|
Medium
|
Larry Price | |||
| Trunk |
Fix Committed
|
Medium
|
Larry Price | |||
| libertine-scope (Ubuntu) |
Fix Released
|
Medium
|
Larry Price | |||
Bug Description
* Run libertine-scope
* Use the filters to filter an application
* Click on another application
* Click "Hide"
* You should be taken back to the dash
Note that the "filtered" application is once again visible, but if you look at the filtering UI the app is still checked.
Related branches
lp:~larryprice/libertine-scope/filter-state
- Christopher Townsend: Approve
- Libertine CI Bot: Approve (continuous-integration)
-
Diff: 350 lines (+179/-43)8 files modifiedscope/apps/action.cpp (+26/-15)
scope/apps/action.h (+21/-15)
scope/apps/scope.cpp (+14/-1)
scope/apps/scope.h (+1/-0)
tests/CMakeLists.txt (+2/-0)
tests/mock_hidden_apps.h (+32/-0)
tests/test_action.cpp (+82/-0)
tests/test_query.cpp (+1/-12)
lp:~townsend/libertine-scope/release-1.3.2
- Larry Price: Approve
- Libertine CI Bot: Pending (continuous-integration) requested
-
Diff: 494 lines (+203/-57)15 files modifiedCMakeLists.txt (+1/-1)
debian/changelog (+11/-0)
scope/apps/action.cpp (+26/-15)
scope/apps/action.h (+21/-15)
scope/apps/config.h.in (+1/-3)
scope/apps/libertine.cpp (+1/-2)
scope/apps/libertine.h (+1/-1)
scope/apps/query.cpp (+7/-5)
scope/apps/query.h (+2/-2)
scope/apps/scope.cpp (+14/-1)
scope/apps/scope.h (+1/-0)
tests/CMakeLists.txt (+2/-0)
tests/mock_hidden_apps.h (+32/-0)
tests/test_action.cpp (+82/-0)
tests/test_query.cpp (+1/-12)
- Libertine CI Bot: Approve (continuous-integration)
- Libertine Developers: Pending requested
-
Diff: 18 lines (+11/-0)1 file modifieddebian/changelog (+11/-0)
Revision history for this message
| Larry Price (larryprice) wrote | #1 |
| Changed in libertine-scope (Ubuntu): | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
Revision history for this message
| Libertine CI Bot (libertine-ci-bot) wrote | #2 |
| Changed in libertine-scope: | |
| status: | In Progress → Fix Committed |
| Changed in libertine-scope (Ubuntu): | |
| status: | Triaged → In Progress |
| assignee: | nobody → Larry Price (larryprice) |
| Changed in canonical-devices-system-image: | |
| importance: | Undecided → Medium |
| milestone: | none → 13 |
| status: | New → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in libertine-scope (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This problem seems to stem from the CannedQuery created in action.cpp. This Query doesn't have a filter_state or query_str set, yet the dash hasn't forgotten about the old filter state.