volume update API misses metadata checking

[wanghao]

Now Cinder can update user metadata by updating volume_metadata API or updating volume API.
But update volume API misses the checking of metadata properties, that will cause 500 error if metadata value is larger than 255 characters.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/329352

[OpenStack Infra (hudson-openstack)]

Change abandoned by wanghao (<email address hidden>) on branch: master
Review: https://review.openstack.org/329352
Reason: Since xiexs has merged this approach in patch: https://review.openstack.org/330913. So let's review it and we'll work together on it. This patch will be abandoned.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/330913
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=86f645a05f177dc16e505cdf8101aaf71c95c7c4
Submitter: Jenkins
Branch: master

commit 86f645a05f177dc16e505cdf8101aaf71c95c7c4
Author: xiexs <email address hidden>
Date: Thu Jun 23 04:13:50 2016 -0400

    Add validation for the metadata properties

    Besides /volume_metadata API, the volume metadata can also
    be controlled(i.e. create/update) by /volumes along with
    name and description. But there is no validation for
    /volumes API, so that 500 error will be encountered
    while invalid metadata specified.

    This patch adds validation logic for it and meanwhile
    some test cases as well.

    Co-Authored-By: wanghao <email address hidden>

    Change-Id: I1c621c3d33403b197e0b8e99493ef9817d35d8b9
    Closes-Bug: #1593588
    Closes-Bug: #1592331

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/cinder 9.0.0.0b3 development milestone.