Any message with more than one variable should use named interpolation instead of positional

[zhang.xiuhua]

Any message with more than one variable should use named interpolation instead of positional, to allow translators to move the variables around in the string to account for differences in grammar and writing direction.

For example, do not do this:

# WRONG
raise ValueError(_('some message: v1=%s v2=%s') % (v1, v2))
Instead, use this style:

# RIGHT
raise ValueError(_('some message: v1=%(v1)s v2=%(v2)s') % {'v1': v1, 'v2': v2})

Refer to this document:
http://docs.openstack.org/developer/oslo.i18n/guidelines.html

[Cindy Lu (clu-m)]

Patch here: https://review.openstack.org/#/c/328614/

[David Lyle (david-lyle)]

I'm dubious of the benefits of changing existing code to accommodate new external recommendations. It's not even necessary for python v3 compatibility. I view responding to changing external guidelines in the light of:
1) does this fix broken behavior
2) does this provide a marked improvement over the existing code?
3) is this required for future changes?

This seems to meet none of those. I will approve the first patch, but I really don't want to see a long string of related patches. Or, I would prefer one blanket patch to cover all cases at once.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/328902
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e6c7c3364191b69266f5bae762f4abbb8161dc76
Submitter: Jenkins
Branch: master

commit e6c7c3364191b69266f5bae762f4abbb8161dc76
Author: zhang.xiuhua <[e-mail]>
Date: Mon Jun 13 16:39:17 2016 +0800

    Modify warning message

    refer to this link:
    http://docs.openstack.org/developer/oslo.i18n/guidelines.html

    Partial-bug: #1592300

    Change-Id: I655628bf5e23dbc66a6ecd4dedba0c7abc5e2100

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/331510

[OpenStack Infra (hudson-openstack)]

Change abandoned by zhang.xiuhua ([e-mail]) on branch: master
Review: https://review.openstack.org/329774
Reason: abandon it

[OpenStack Infra (hudson-openstack)]

Change abandoned by zhang.xiuhua ([e-mail]) on branch: master
Review: https://review.openstack.org/331510
Reason: abandon

[Rob Cresswell (robcresswell-deactivatedaccount)]

Looks like all changes were merged, so marking as Fix Released.