libvirt: cleanup of a volume backed instance resize leaves behind the instance directory

[Lee Yarwood]

Description
===========
Attempts to cleanup a volume backed instance resize leaves behind the instance directory and additional disk files. This seems to relate to the following change and the additional imagebackend calls made in _cleanup_resize :

    libvirt: Fix/implement revert-resize for RBD-backed images
    https://review.openstack.org/#/c/228505/

Steps to reproduce
==================
* Create a volume backed instance.
* Shutdown the instance.
* resize/migrate the instance to another host.
* Review the instance directory on the source host.

Expected result
===============
The instance directory on the source host is removed.

Actual result
=============
The instance directory on the source host remains and is also populated with a previously unused `disk` file and disk.info file.

Environment
===========
1. Exact version of OpenStack you are running. See the following

# git rev-parse HEAD
6e2e1dc912199e057e5c3a5e07d39f26cbbbdd5b

2. Which hypervisor did you use?
   libvirt + kvm

2. Which storage type did you use?
   (For example: Ceph, LVM, GPFS, ...)
   LVM/iSCSI

3. Which networking type did you use?
   N/A

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/329030

[Timofey Durakov (tdurakov)]

Managed to reproduce this issue for non-volume-backed instances, for non-shared-storage env, and for nfs-shared storage both. Steps to reproduce: are almost the same, the only difference, instance was booted from image/ephemeral

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/382030

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/329030
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/414709

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/414710

[Oisin (oisin-omalley)]

I can confirm I'm also seeing this issue in Nova 14.0.2 in Newton. Have you made any further progress resolving?

[Feodor Tersin (ftersin)]

@Oisin, the alternative solution is merged in master (Pike) and Okata. No Newton support, as i know. See LP #1666831

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/414709
Reason: This review is > 4 weeks without comment, and is not mergable in it's current state. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/382030
Reason: This review is > 4 weeks without comment, and is not mergable in it's current state. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/414710
Reason: This review is > 4 weeks without comment, and is not mergable in it's current state. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.