Ignore "hide tab bar when only 1 open" setting in GTK+ <2.10

[Johannes Sasongko]

The "hide tab bar when only 1 open" setting requires the page-added and page-removed signal of GtkNotebook, which are only available in GTK+ >=2.10 (Exaile doesn't run in 2.8 anymore).

[Shayne (shaynetonio)]

Do you have anything in mind for this? The two lines of code in main.py for page-added and page-removed are calling only one method to show/hide the toolbar -- i don't see any other functionality aside from this. Perhaps we can just wrap this around an exception handler and move away from the aesthetics? Or did you have something else in mind here?

Shayne

[Johannes Sasongko (sjohannes)]

Nope, I'm fine with that as long as it doesn't introduce weird behaviour
(i.e. when the compatibility mode is in effect, the tab bar should
always be shown, not hidden).

[vijay krishna ramesh (vijay-ramesh06)]

This still hasn't been fixed. I'm running Ubuntu Dapper (the latest LTS version) and in addition to not being able to build a .deb (as the dependencies from the source require python-dbus & Dapper has python2.4-dbus; got around this by doing make install instead of dpkg-buildpackage) as well as having to install a newer version of mutagen from source (from http://www.sacredchao.net/~piman/software/mutagen-1.8.tar.gz), I ended up having to hack /usr/local/lib/exaile/xl/gui/main.py to comment out those two lines (page-added and page-removed). The first two complaints are more of a problem with Dapper than Exaile, per se, but would definitely stop most "normal" users of the latest Ubuntu LTS version from using Exaile. The latter problem, however, could easily be fixed with a check for GTK+>=2.10. With my hacked version, I notice no problems except some warning mesages (ie, AttributeError: 'gtk.Notebook' object has no attribute 'set_tab_reorderable'). Is anybody planning on implementing this? Or should I? Not sure of the process for doing development as I've never contributed to any big pre-existing GPL project...

[Johannes Sasongko (sjohannes)]

The fix hasn't been released officially; it's just fixed in the development version.

[vijay krishna ramesh (vijay-ramesh06)]

ah OK sounds good, thanks for the info