Nested stack creates are not cancelled when a sibling resource fails

Bug #1591341 reported by Zane Bitter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Zane Bitter
Liberty
Won't Fix
Undecided
Unassigned
Mitaka
Won't Fix
Undecided
Unassigned
Newton
Fix Released
High
Zane Bitter

Bug Description

This is the create equivalent of the update problem in bug 1446252 (which is still with us - see bug 1591337).

If a resource fails during stack creation and one of its sibling resources is an in-progress nested stack, the nested stack will not be cancelled but continue running until it succeeds, fails or times out. This means the user will be unable to (successfully) commence an update to fix the initial create failure until this has occurred. (Bug 1475057 has some more details too.)

This issue has been around since nested stacks were separated out and put behind an RPC interface in Kilo. However, a backport to Mitaka or earlier is probably infeasible.

Revision history for this message
Zane Bitter (zaneb) wrote :

(Note that convergence is not affected)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to heat (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/341817

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/341818

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to heat (master)

Reviewed: https://review.openstack.org/341817
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=1075d7e983ea913890729f0d934466b83e368203
Submitter: Jenkins
Branch: master

commit 1075d7e983ea913890729f0d934466b83e368203
Author: Zane Bitter <email address hidden>
Date: Fri Jul 22 11:14:54 2016 -0400

    Allow stack create operations to be cancelled

    We want to be able to use the internal API to gracefully cancel a create
    operation that is in progress. (Users can still use the stack-cancel-update
    command only to cancel an update, not the initial creation of a stack.)

    Change-Id: I204f13d9ed7b826c6c5ac94126e23f2ed6d7e97f
    Related-Bug: #1591341

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/341818
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=1266323eff92125fb99be7ec01354082f978373c
Submitter: Jenkins
Branch: master

commit 1266323eff92125fb99be7ec01354082f978373c
Author: Zane Bitter <email address hidden>
Date: Fri Jul 22 11:14:54 2016 -0400

    Cancel nested stack creation when sibling fails

    When a resource fails and a sibling resource in the same stack is a nested
    stack and is being created, we should (gracefully) cancel the creation of
    the nested stack. This allows the user to correct the issue and try to
    recover the stack with a stack update within a reasonable period of time.
    Otherwise, they have to wait for the entire nested stack to complete, fail
    or time out before they will be able to successfully do an update to
    correct the problem.

    Change-Id: I02c3894718d595282f57ca63dc2c2ba9b7baa440
    Closes-Bug: #1591341

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 7.0.0.0b3

This issue was fixed in the openstack/heat 7.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.