ZFSSA iSCSI driver volume backup/restore doesn't work

Bug #1591332 reported by Kedar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Critical
Kedar

Bug Description

The backup and restore methods in the driver are no-op. They need to be deleted so that the base driver's functionality can be leveraged.

Kedar (kedar-vidvans)
Changed in cinder:
assignee: nobody → Kedar (kedar-vidvans)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/328465

Changed in cinder:
status: New → In Progress
Revision history for this message
Xing Yang (xing-yang) wrote :

These two driver methods are used in Liberty for backup and restore, but are no longer called in Mitaka and Newton. This fix needs to be backported to Liberty.

Changed in cinder:
importance: Undecided → Critical
tags: added: liberty-backport-potential
Xing Yang (xing-yang)
Changed in cinder:
milestone: none → newton-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/328465
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=c68892af439c1365e2708ed7ad532a0b46b7f5a0
Submitter: Jenkins
Branch: master

commit c68892af439c1365e2708ed7ad532a0b46b7f5a0
Author: kedar-vidvans <email address hidden>
Date: Fri Jun 10 15:55:12 2016 -0400

    Backup and restore broken in zfssaiscsi driver

    Volume backup and restore functionality in the iscsi driver needs
    to fall back on the base driver's implementation.
    This fix is for the driver in Liberty and needs to be backported.

    Change-Id: I3f2751a89241a7779c964746dc815dd9b23ef40b
    Closes-Bug: #1591332

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/329446

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/cinder 9.0.0.0b2

This issue was fixed in the openstack/cinder 9.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (stable/liberty)

Change abandoned by Sean McGinnis (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/329446
Reason: This review is > 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.