Shared filter is broken for QoS policies since Mitaka

Bug #1591222 reported by Ihar Hrachyshka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Ihar Hrachyshka

Bug Description

The filter was working in Liberty, but was broken in Mitaka when
the field became synthetic as part of RBAC enablement for the resource.

Tags: qos
tags: added: qos
Changed in neutron:
assignee: nobody → Ihar Hrachyshka (ihar-hrachyshka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/328313

Changed in neutron:
status: New → In Progress
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

This is needed to complete api test coverage for qos policies for sorting/pagination, that is related to blueprint adopt-oslo-versioned-objects-for-db, targeting to N2.

Changed in neutron:
milestone: none → newton-2
importance: Undecided → Medium
tags: added: mitaka-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/328313
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=389f7b0b08455b77db24d41280e8cc00a0d2260b
Submitter: Jenkins
Branch: master

commit 389f7b0b08455b77db24d41280e8cc00a0d2260b
Author: Ihar Hrachyshka <email address hidden>
Date: Fri Jun 10 16:03:31 2016 +0200

    qos: fix shared filter for policies

    The filter was working in Liberty, but was broken in Mitaka when
    the field became synthetic as part of RBAC enablement for the resource.

    _get_collection already knows how to handle the filter on database
    level, so we just need to register the filter to pass it deeper into
    db_api.

    Change-Id: I40657bd15d9bf1e2bc6b0224254c916c35391cd1
    Closes-Bug: #1591222

Changed in neutron:
status: In Progress → Fix Released
tags: added: neutron-proactive-backport-potential
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 9.0.0.0b2

This issue was fixed in the openstack/neutron 9.0.0.0b2 development milestone.

Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

This would require several featureful patches to backport. Specifically,

- (pieces of) I7dafc4dbd80f0ac35dbc2c2f30e56e441f5b1fc0 to switch get_objects to _get_collection (specifically, neutron/objects/db/api.py changes)
- whole I106a21efe42f848ee18cb8349fe89afd404d25b1 to allow defining additional query filters
- the patch in question itself.

I am not really sure it's worth the hassle, but leaving the bug marked for proactive backport for now.

tags: removed: neutron-proactive-backport-potential
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

Not critical for Mitaka backport.

tags: removed: mitaka-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.