Unexpected error when configuring interfaces of 'error' node

[Julia Aranovich]

Steps to reproduce in Fuel UI:

1. create an environment (default wizard settings)
2. add a node with 'error' status
3. go to interfaces configuration screen for the node
4. change network assignment to enable Apply button and save the changes

Expected result: the changes should be saved successfully as well as interfaces are configurable for 'error' nodes.

Actual result: PUT /api/nodes/5/interfaces returns 400 Bad Request with the response: {"message": "Node '5': Interfaces configuration can't be changed after or during deployment.", "errors": []}

BUT there was no any deployment process in the environment.

[Maciej Relewicz (rlu)]

Julia please provide more information about version on which problem occurs, or attach diagnostic snapshot.

[Aleksey Kasatkin (alekseyk-ru)]

It can be seen here: https://review.openstack.org/#/c/322876/ - such changes are allowed for ready, stopped, discover nodes and nodes with discovery error. it is not allowed for nodes with deployment or other errors.

[Julia Aranovich (jkirnosova)]

According to the https://review.openstack.org/#/c/322876/ UI should forbid ifc configuration for an error node if it's error_type attribute is not equal to 'discover'.
Node described in the ticket has error_type=null. So, will close this as Invalid

[Julia Aranovich (jkirnosova)]

Reopened to fix checking of node error type on UI.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/329370

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/329370
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=420fe4d5169de6e5fb45b6aa818b06e07f7352c8
Submitter: Jenkins
Branch: master

commit 420fe4d5169de6e5fb45b6aa818b06e07f7352c8
Author: Julia Aranovich <email address hidden>
Date: Tue Jun 14 13:48:49 2016 +0300

    Allow to modify interfaces of error nodes with error_type=discover only

    If a node has error status, it's error_type attribute should be also checked
    to make a decision if it possible to configure the node interfaces or not.

    Closes-Bug: #1589881

    Change-Id: I664a57eae27ddc255610e2b4d5238b3d92c9e802

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/329793

[OpenStack Infra (hudson-openstack)]

Change abandoned by Julia Aranovich (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/329793
Reason: The issue is fixed in https://review.openstack.org/#/c/334538/

[Julia Aranovich (jkirnosova)]

In https://bugs.launchpad.net/fuel/+bug/1592998 decided to allow interfaces configuration for 'error' node with 'deploy' error type.

So, both 'discover' and 'deploy' error types don't lock node configuration.

[Dmitry Belyaninov (dbelyaninov)]

How to move a node to error state with "discover" state?

[Alexey. Kalashnikov (akalashnikov)]

Verified with FakeUI on stable/mitaka from 14.09.2016
With manual updating nailgun database for getting errors nodes.