Nailgun validates hidden setting groups

[Julia Aranovich]

Steps to reproduce in Fuel UI:

1. create an environment (default wizard settings)
2. go to Settings tab, OpenStack Services subtab
3. check "Install Ceilometer and Aodh" and "Use external Mongo DB" settings, "External MongoDB" setting section should appear on the screen
4. input in an invalid value into "MongoDB hosts IP" field to raise a validation error on UI (in my case the field was autocompleted with "admin" value, see the attached screenshot)
5. uncheck "Install Ceilometer and Aodh" and "Use external Mongo DB" settings. "External MongoDB" setting section should disappear from the screen and validation error should not be shown as well as the section was closed.
6. check "Install Sahara" checkbox to enable "Save Settings" button
7. click "Save Settings" button to save the change

Expected result: the change is saved successfully, no error occurred.

Actual result: there is a Nailgun error, PUT /api/clusters/5/attributes failed with 400 Bad Request and the response: {"message": "[hosts_ip] Invalid hosts ip sequence", "errors": []}

The following data was sent to Nailgun http://paste.openstack.org/show/cVKQFEYSmmMg6Ncqo1UR/

Looks like Nailgun validates values in hidden sections, like "External MongoDB" in the case.

[Julia Aranovich (jkirnosova)]

I think this is Nailgun issue, it should not validate/process setting sections that are hidden by restrictions.

[Dmitriy Kruglov (dkruglov)]

Another occurrence of the issue https://custom-ci.infra.mirantis.net/job/10.0.custom.system_test/563/console (this is not a swarm but an acceptance tests, i.e. it is executed in CI but not on a daily basis).
MOS 9.0, ISO build #496 (RC2).

[Nikolay Tymtsiv (ntymtsiv)]

@jkirnosova How does fuel-ui mark hidden by restrictions setting sections? Nailgun does not know is this setting hidden or not. IMO Fuel-UI should not send values to nailgun in this case.

[Julia Aranovich (jkirnosova)]

Nikolay, Fuel UI doesn't display hidden settings (see #4 step from the bug description).
To check if setting or setting section is hidden, UI code processes its restrictions attribute:

https://github.com/openstack/fuel-web/blob/stable/mitaka/nailgun/nailgun/fixtures/openstack.yaml#L946-L949

Here you can see that the whole section has a restriction. And section settings should not be validated if any restriction is satisfied (no matter what action it has: 'disable' or 'hide'). Satisfied restriction means that the setting/section isn't active.

[Oleksiy Molchanov (omolchanov)]

Should be fixed by https://review.openstack.org/#/c/420777/

[Oleksiy Molchanov (omolchanov)]

Oh, sorry, wrong bug id =)