missing argument for ssh-keygen?

[Gergely Sipos]

On the Git setup page of the upstream training guide I get an error when trying to generate my ssh key:

sipos@sipos-VirtualBox:~$ ssh-keygen -b 4096 -c "<email address hidden>"
Too many arguments

I think a '-c' is missing before the email address. So correctly:

ssh-keygen -t rsa -b 4096 -c "<email address hidden>"

Regards,
Gergely

-----------------------------------
Release: 0.0.1 on 2016-05-30 13:41
SHA: a7518db7b3c28b0c7ee3f622fd8f3f78623bb09c
Source: http://git.openstack.org/cgit/openstack/training-guides/tree/doc/upstream-training//git.rst
URL: http://docs.openstack.org/upstream-training/git.html

[Ian Y. Choi (ianychoi)]

-C instead of -c seems to be correct, according to
 1) https://help.github.com/articles/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent/
 2) ssh-kengen usage:

usage: ssh-keygen [-q] [-b bits] [-t dsa | ecdsa | ed25519 | rsa | rsa1]
                  [-N new_passphrase] [-C comment] [-f output_keyfile]
       ssh-keygen -p [-P old_passphrase] [-N new_passphrase] [-f keyfile]
       ssh-keygen -i [-m key_format] [-f input_keyfile]
       ssh-keygen -e [-m key_format] [-f input_keyfile]
       ssh-keygen -y [-f input_keyfile]
       ssh-keygen -c [-P passphrase] [-C comment] [-f keyfile]

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/338379

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/338379
Committed: https://git.openstack.org/cgit/openstack/training-guides/commit/?id=740cc8f20a5049910915d6522d54f9008e079b60
Submitter: Jenkins
Branch: master

commit 740cc8f20a5049910915d6522d54f9008e079b60
Author: Ian Y. Choi <email address hidden>
Date: Thu Jul 7 01:09:17 2016 +0900

    [upstream] Add missing -C option on ssh-keygen

    The ssh-command in "Setup and Learn GIT" section
    returns an error because -C option is missing.

    Change-Id: I3e8a56155ef4d438147efebef35fafd6619fb14f
    Closes-bug: #1589835